Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid repo url for GNU Solfege #30

Open
tmkontra opened this issue Dec 23, 2018 · 2 comments
Open

Invalid repo url for GNU Solfege #30

tmkontra opened this issue Dec 23, 2018 · 2 comments

Comments

@tmkontra
Copy link

Hi @mahmoud !

I got started on the h-index/altmetric investigation we discussed on reddit: https://github.com/ttymck/pycite

In doing so, I noticed GNU Solfege is listed with a repo URL of:
http://git.savannah.gnu.org/cgit/solfege.git

When I try to clone that (using gitpython), it throws this error:

git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git clone --branch=master -v http://git.savannah.gnu.org/cgit/solfege.git /home/tkontra551/.cache/pycite/GNU Solfege
  stderr: 'Cloning into '/home/$USER/.cache/pycite/GNU Solfege'...
fatal: repository 'http://git.savannah.gnu.org/cgit/solfege.git/' not found

This appears to be the proper git repo URI for the project:
https://git.savannah.gnu.org/git/solfege.git/

@tmkontra tmkontra changed the title Invalid GNU Solfege repo url Invalid repo url for GNU Solfege Dec 23, 2018
@mahmoud
Copy link
Owner

mahmoud commented Dec 24, 2018

First off, very cool! Maybe releasing early, right before the holidays was the right call after all :)

So my thought on this was that all the links should be nice and clickable to a user reading the README, as the solfege one is.

We can store a separate clone_url for projects when the repo_url can't be trivial transformed into a URL that is git clone-able. I estimate there's probably a dozen of those.

Now I'm off to skim pycite! :)

@tmkontra
Copy link
Author

tmkontra commented Dec 24, 2018

If we're considering the yaml to be the API, clients can implement this "intelligent git-clone-url finder"
(comments, suggestions welcome)
https://github.com/ttymck/pycite/pull/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants