Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: triage Dependabot updates #15420

Open
lucasgonze opened this issue May 6, 2024 · 3 comments
Open

Proposal: triage Dependabot updates #15420

lucasgonze opened this issue May 6, 2024 · 3 comments
Labels
type: proposal Proposals and design documents

Comments

@lucasgonze
Copy link
Contributor

lucasgonze commented May 6, 2024

Problem

Dependabot alerts are up to 300, from 23 about a year ago.

By severity:
image

Solution

I will work through all alerts for necessary security patches:

  1. Merge any pull requests that don't break the build or any test
  2. Identify and dismiss false positives
  3. Implement upstream patches when feasible
  4. Analyze dependency paths to CVEs and manually update packages as necessary

Non-goals

This work excludes patching Magma source code. In places where an upgrade requires changes to, for example, React code, that is out of scope.

Work beyond 6-8 weeks.

Bid

I estimate this work will take 6-8 weeks. I am asking for $6,000 to perform it.

Note that I am submitting this bid as the first party, under my own name, and not via OSPOCO.

Acceptance:

  • No upgrades at severity Critical (15) or High (88) will be untriaged. I will either merge a PR, create a PR, or write a ticket when further engineering is needed.
  • All items at severity Moderate (181) will be reviewed. They will be dismissed when irrelevant, merged when no test is broken, manually upgraded when possible. When none of the above is possible, I will document the reasons for discussion with the TSC.
  • No items at severity Low (16) will be left.
@lucasgonze lucasgonze added the type: proposal Proposals and design documents label May 6, 2024
@lucasgonze
Copy link
Contributor Author

lucasgonze commented May 6, 2024

TSC conversation notes:

  1. Ubuntu will need an upgrade to 22.0.4, and that will likely cause churn in the open alerts.
  2. Not ready for a vote on acceptance yet - bring up again next week w/ TSC.

@lucasgonze
Copy link
Contributor Author

lucasgonze commented May 13, 2024

TSC conversation notes:

The work may be much larger than documented here. How to package it as a proposal?

  • Identify trivial items
  • Click the button on trivial items
  • Document non-trivial items

Continue discussion offline and next week.

@lucasgonze
Copy link
Contributor Author

Alternate way to package this up: leave no critical or high severity upgrades behind. Every one should have been researched and routed, with trivial work done and non-trivial work in the engineering pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: proposal Proposals and design documents
Projects
None yet
Development

No branches or pull requests

1 participant