Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: CI Cleanup #15382

Open
tmdzk opened this issue Feb 22, 2024 · 6 comments
Open

Proposal: CI Cleanup #15382

tmdzk opened this issue Feb 22, 2024 · 6 comments
Labels
tsc-discussion TSC discussions about process, proposal, amendments, type: proposal Proposals and design documents

Comments

@tmdzk
Copy link
Collaborator

tmdzk commented Feb 22, 2024

CI Cleanup

Problem

We are currently using Github Action as our main CI component, GHA UI is definitely not the best and It can be messy, It's very important to have a clean and efficient CI as an open source project, when external contributor open a PR you can see 102 jobs being attached to your pull request. On top of that the Github Action UI can be overwhelming. The proposal is about cleaning all jobs, decommissioning all the unrelevant/unused jobs.

Solution

Multiple things can be done:

  • Move all related jobs under the same workflow to avoid having 25 workflows for 1 component.
  • Bring back the magma CI dashboard that had all the useful information
  • Decommission all the job that are not used anymore
  • Merge jobs that could be run at the same time

Non-goals

None

@tmdzk tmdzk added the type: proposal Proposals and design documents label Feb 22, 2024
@lucasgonze
Copy link
Contributor

A security problem with centralizing workflows is that it becomes hard to reason about the security properties of permissions needed for each one. However there could be a smaller number of workflows, where they are organized by permissions.

Decommissioning and merging is a great idea.

I have no opinion on the dashboard.

@jordanvrtanoski jordanvrtanoski added the tsc-discussion TSC discussions about process, proposal, amendments, label Feb 22, 2024
@jordanvrtanoski
Copy link
Contributor

jordanvrtanoski commented Feb 22, 2024

I am fully aligned with the proposal, @panyogesh can you please evaluate it as well. If ok, let's have budget for it and let's bring it on TSC for vote.
The one workflow will be organized in multiple steps, let's verify if the security can be controlled on the steps

@panyogesh
Copy link
Contributor

+1, Proposal looks fine.

@lucasgonze
Copy link
Contributor

@tmdzk Are you asking for budget for this, or is it within your current funding?

@tmdzk
Copy link
Collaborator Author

tmdzk commented Mar 11, 2024

It's within current funding

@lucasgonze
Copy link
Contributor

lucasgonze commented May 20, 2024

@tmdzk Can you provide an update on the state of this?

Update later: Tim says he is at 25%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tsc-discussion TSC discussions about process, proposal, amendments, type: proposal Proposals and design documents
Projects
None yet
Development

No branches or pull requests

4 participants