Use with-editor for magit-run and friends

[david-greene-cb]

It would be nice to use with-editor to executed the commands prefixed by !. This way any scripts that might invoke something interactive like a rebase would work naturally. Alternatively, new suffix commands could provide the same functionality as existing suffix commands (e.g. !!) but run them using with-editor.

[tarsius]

It would be nice to use with-editor to executed the commands prefixed by !.

I don't understand where you want to do this. In a terminal maybe? Maybe you are looking for with-editor-async-shell-command and similar commands? Please provide an example (not of a command that you might want to invoke, but of how you want to invoke it).

[david-greene-cb]

!! git <my git plugin>

Where <my git plugin> does a rebase.

Yes, with-editor-async-shell-command will do what I want, without the benefit of switching to the project root first.

[tarsius]

The part that I did not understand is that "the commands prefixed by !" means "the commands available from magit-run (bound to !)". (Though admittedly when you mentioned "suffix commands (e.g. !!)", I should have made the connection. (I don't really us magit-run, so ! and !! didn't trigger any memory.)

[tarsius]

Done in 28bcd29.