Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for viewing Github discussions #730

Closed
kjambunathan opened this issue Dec 14, 2024 · 4 comments
Closed

Support for viewing Github discussions #730

kjambunathan opened this issue Dec 14, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@kjambunathan
Copy link

kjambunathan commented Dec 14, 2024

magit v4.1.2-24-g46824fb4 does NOT support viewing of discussions in a github repo. For example, I cannot view https://github.com/kjambunathan/org-mode-ox-odt/discussions in the magit-status buffer.

(I can view issues and PR just fine)

cf. Using the GraphQL API for Discussions: Learn how to use the GitHub Discussions GraphQL API

@kjambunathan kjambunathan changed the title FR: Support for viewing discussions in a github repo FR: Support for viewing discussions in a github repo through forge Dec 14, 2024
@tarsius
Copy link
Member

tarsius commented Dec 14, 2024

Discussions didn't exist when I created Forge, but of course I already plan to add support. I will probably do it in the first quarter of 2025.

There's already a discussions feature branch, from half a year ago. A lot has changed since then on main and discussions wasn't quite working back when I created it, so you should not actually use it, but it gives an idea of what this involves and will be a good starting point, once I am ready to resume this work.

@tarsius tarsius added the enhancement New feature or request label Dec 14, 2024
@tarsius tarsius changed the title FR: Support for viewing discussions in a github repo through forge Support for viewing discussions in a github repo through forge Dec 17, 2024
@tarsius tarsius changed the title Support for viewing discussions in a github repo through forge Support for viewing Github discussions Dec 17, 2024
@dcunited001
Copy link

Thanks for your work on this. I'm hoping to start using Forge again soon

  • Sent from my forge.el

@tarsius
Copy link
Member

tarsius commented Mar 27, 2025

Implemented in 3aa6d2a (among others).

@tarsius tarsius closed this as completed Mar 27, 2025
@kjambunathan
Copy link
Author

kjambunathan commented Mar 31, 2025

Implemented in 3aa6d2a (among
others).

Thanks for this.

The support for Discussions looks good on the first run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants