Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request comments that require resolution not showing up in "visit topic" buffer #396

Closed
BigTheta opened this issue Sep 1, 2021 · 1 comment
Closed

Pull request comments that require resolution not showing up in "visit topic" buffer #396

BigTheta opened this issue Sep 1, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@BigTheta
Copy link

BigTheta commented Sep 1, 2021 •
edited
Loading

I understand that resolving conversations from within forge is not support right now, but we should at least be able to see the comments when we are viewing the PR in forge?

How to reproduce:

  1. Create a pull-request
  2. In github:
    a. Leave a comment on the pull-request
    b. Select "add a single comment"
    c. leave another comment
    d. Select "Start a review" and select the "request changes" bubble before confirming
  3. From forge:
    a. Pull topics
    b. Visit the pull request in forge

The comments requiring resolution are not included in the topic view, while the single comment is.
@tarsius
Copy link
Member

tarsius commented Sep 1, 2021

Yes review comments aren't supported. See #75.

@tarsius tarsius added the duplicate This issue or pull request already exists label Sep 1, 2021
@tarsius tarsius closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarsius @BigTheta