Is it possible to approve a pull request from within forge?

[BigTheta]

I have checked the manual, FAQ and reddit, I don't see anywhere where its even been asked before.

I was asked to review a pull request, I was able to view the commits and comment on the PR. Now, I would like to approve the PR. I know gh has this functionality. It seems like the sort of functionality forge was intended to support?

[tarsius]

Not yet, I believe. Supporting it isn't a top priority but eventually it will probably be implemented. (The projects I am involved in for the most part work by merging or not merging pull-requests without explicitly and beforehand approve or reject it.)

[tarsius]

Is it possible to join/approve a pull request from within forge?

I just remembered that I implemented this quite recently in 3112ade. It's available from the merge menu, but not by default so...

[tarsius]

Certain transient popups hide some of their suffix commands by default. These additional suffixes can be enabled interactively. TL;DR Enter the transient as usual and type C-x l.

_{This is a canned response; it may not apply 100% in this case.}

[tarsius]

I have checked the manual,

I've just added it to the manual.

[BigTheta]

Thank you. Much appreciated.

[BigTheta]

Sorry, I never actually attempted this until just now.

I just remembered that I implemented this quite recently in [3112ade]

To be clear, you are taking about merging (not approving?) I don't see anything in that commit regarding approving reviews.

It's available from the merge menu, but not by default so...

I'm looking at the merge menu with suffixes enabled and I still don't see anything regarding approving the topic?

[tarsius]

To be clear, you are taking about merging (not approving?)

Yeah. Your use of the word "join" confused me. That sounded like a synonym for "merge".

So no. Approving still isn't supported and adding support is a low priority.

[aiguofer]

Check out https://github.com/wandersoncferreira/code-review (I just found it looking for better ways to do reviews using forge)

Slightly weird switching between forge and code-review, but they do integrate fairly well.