Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Fonts QA #1

Open
m4rc1e opened this issue Jun 10, 2019 · 0 comments
Open

Google Fonts QA #1

m4rc1e opened this issue Jun 10, 2019 · 0 comments

Comments

@m4rc1e
Copy link

m4rc1e commented Jun 10, 2019

In order to host the font on Google Fonts, the fonts will have to pass our linter, Fontbakery

The fonts have the following issues:

Fontbakery report

Fontbakery version: 0.6.12.dev19+g6638c122.d20190308

[2] Family checks
🔥 FAIL: Check font has a license.
  • com.google.fonts/check/family/has_license
  • 🔥 FAIL No license file was found. Please add an OFL.txt or a LICENSE.txt file. If you are running fontbakery on a Google Fonts upstream repo, which is fine, just make sure there is a temporary license file in the same folder. [code: no-license]
🔥 FAIL: Check that OS/2.fsSelection bold & italic settings are unique for each NameID1

[17] Gold-Bold.ttf
🔥 FAIL: Checking OS/2 fsType.
  • com.google.fonts/check/fstype
  • 🔥 FAIL OS/2 fsType is a legacy DRM-related field.
    In this font it is set to 8 meaning that:
    The font may be embedded but must only be installed temporarily on other systems.
    No such DRM restrictions can be enabled on the Google Fonts collection, so the fsType field must be set to zero (Installable Embedding) instead.
    Fonts with this setting indicate that they may be embedded and permanently installed on the remote system by an application.

More detailed info is available at:
https://docs.microsoft.com/en-us/typography/opentype/spec/os2#fstype

🔥 FAIL: Substitute copyright, registered and trademark symbols in name table entries.
🔥 FAIL: License URL matches License text on name table?
🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries?
🔥 FAIL: Copyright notices match canonical pattern in fonts
  • com.google.fonts/check/font_copyright
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
    But instead we have got: 'Copyright © 2018 by jaiki. All rights reserved.'
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
    But instead we have got: 'Copyright © 2018 by jaiki. All rights reserved.'
🔥 FAIL: Checking OS/2 fsSelection value.
  • com.google.fonts/check/fsselection
  • 🔥 FAIL OS/2 fsSelection REGULAR bit should be reset. [code: bad-REGULAR]
  • 🔥 FAIL OS/2 fsSelection BOLD bit should be set. [code: bad-BOLD]
🔥 FAIL: Checking head.macStyle value.
🔥 FAIL: Check name table: FONT_FAMILY_NAME entries.
🔥 FAIL: Check name table: FONT_SUBFAMILY_NAME entries.
🔥 FAIL: Check name table: TYPOGRAPHIC_FAMILY_NAME entries.
🔥 FAIL: Check name table: TYPOGRAPHIC_SUBFAMILY_NAME entries.
🔥 FAIL: PPEM must be an integer on hinted fonts.
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent.
  • com.google.fonts/check/family/win_ascent_and_descent
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1084, but got 956 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value should be equal or greater than 680, but got 244 instead [code: descent]
🔥 FAIL: Checking OS/2 Metrics match hhea Metrics.
🔥 FAIL: Glyph names are all valid?

A glyph name may be up to 31 characters in length, must be entirely comprised of characters from the following set: A-Z a-z 0-9 .(period) (underscore). and must not start with a digit or period. There are a few exceptions such as the special character ".notdef". The glyph names "twocents", "a1", and "" are all valid, while "2cents" and ".twocents" are not.

🔥 FAIL: Font contains unique glyph names?
🔥 FAIL: Name table entries should not contain line-breaks.
  • com.google.fonts/check/name/line_breaks
  • 🔥 FAIL Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
  • 🔥 FAIL Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

[11] Gold-Regular.ttf
🔥 FAIL: Checking OS/2 fsType.
  • com.google.fonts/check/fstype
  • 🔥 FAIL OS/2 fsType is a legacy DRM-related field.
    In this font it is set to 8 meaning that:
    The font may be embedded but must only be installed temporarily on other systems.
    No such DRM restrictions can be enabled on the Google Fonts collection, so the fsType field must be set to zero (Installable Embedding) instead.
    Fonts with this setting indicate that they may be embedded and permanently installed on the remote system by an application.

More detailed info is available at:
https://docs.microsoft.com/en-us/typography/opentype/spec/os2#fstype

🔥 FAIL: Substitute copyright, registered and trademark symbols in name table entries.
🔥 FAIL: License URL matches License text on name table?
🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries?
🔥 FAIL: Copyright notices match canonical pattern in fonts
  • com.google.fonts/check/font_copyright
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
    But instead we have got: 'Copyright © 2018 by jaiki. All rights reserved.'
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
    But instead we have got: 'Copyright © 2018 by jaiki. All rights reserved.'
🔥 FAIL: PPEM must be an integer on hinted fonts.
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent.
  • com.google.fonts/check/family/win_ascent_and_descent
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1084, but got 956 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value should be equal or greater than 680, but got 244 instead [code: descent]
🔥 FAIL: Checking OS/2 Metrics match hhea Metrics.
🔥 FAIL: Glyph names are all valid?

A glyph name may be up to 31 characters in length, must be entirely comprised of characters from the following set: A-Z a-z 0-9 .(period) (underscore). and must not start with a digit or period. There are a few exceptions such as the special character ".notdef". The glyph names "twocents", "a1", and "" are all valid, while "2cents" and ".twocents" are not.

🔥 FAIL: Font contains unique glyph names?
🔥 FAIL: Name table entries should not contain line-breaks.
  • com.google.fonts/check/name/line_breaks
  • 🔥 FAIL Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
  • 🔥 FAIL Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
0 30 12 119 13 111
0% 11% 4% 42% 5% 39%

Note: The following loglevels were omitted in this report:

  • WARN
  • SKIP
  • INFO
  • PASS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant