Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overwrite “accessModes” to support AWS ebs for k8s volumes #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow overwrite “accessModes” to support AWS ebs for k8s volumes #74

wants to merge 1 commit into from

Conversation

devopsmash
Copy link

@devopsmash devopsmash commented Feb 12, 2025 •
edited
Loading

Summary

  • Allow overwrite “accessModes” to support AWS ebs for k8s volumes
  • Now if you choose persistence, it will attach the new PVC directly to the deployment

Tests

I've added additional custom values file (custom-values.yaml) with the following content:

persistence:
  enabled: true
  dynamicProvisioning: true
  storageClassName: gp3
  size: 10Gi
  accessModes:
  - ReadWriteOnce

Test commands

  • helm template -f .\values.yaml -f .\custom-values.yaml .
  • helm -n mageai upgrade --install mageai -f .\values.yaml -f .\custom-values.yaml .

Notes:

  • I believe that we can omit the .Values.volumes from the helm chart

closes #70

Inspired from the Jenkins helm chart

@devopsmash
Copy link
Author

Hi @wangxiaoyou1993 , please let me now if additional info is needed or if something is unclear.

@wangxiaoyou1993
Copy link
Member

Will review the PR today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overwrite “accessModes” to support AWS ebs for k8s volumes
2 participants
@devopsmash @wangxiaoyou1993