self hosted ntfy

[cirrusflyer]

The older version of notify, I was able to modify my ntfy file had include a custom domain and token. Can you allow for this in the new version?

[mag37]

Ah yes the custom domain was an oversight - thank you! I'll look at adding another variable and changing the current url-line.

Something like NTFY_DOMAIN="ntfy.sh" to the config. And then this change to the template:

-  NtfyUrl="ntfy.sh/${NTFY_TOPIC_NAME}" # e.g. NTFY_TOPIC_NAME=YourUniqueTopicName
+  NtfyUrl="${NTFY_DOMAIN:="ntfy.sh"}/${NTFY_TOPIC_NAME}" # e.g. NTFY_TOPIC_NAME=YourUniqueTopicName

Though where/how is the token used?

[yoyoma2]

That's a good point though - might be many who dont clone it or download it all!
Might need to consider this @vorezal (who I'm including due to them writing all of the new code 😄 )

Is there a way that dockcheck could iterate through NOTIFY_CHANNELS and give an error for those that are not sourced successfully. I put "DSM" into NOTIFY_CHANNELS and nothing was working and no errors. Turns out my notify.sh that I deleted was a symbolic link and notify_DSM.sh was not in the exact directory dockcheck expects. I tested notifications by editing the version number of local scripts and found/fixed the problem but an error message would be nice. Ex:

ERROR: DSM notification is requested by NOTIFY_CHANNELS but notify_DSM.sh is not found.

ERROR: DSM notification is requested by NOTIFY_CHANNELS but notify_v2.sh is not found.

When doing pre-release testing I had a full clone so things worked but the deployment environment does not.

[vorezal]

Definitely an oversight on my part here. I've started working on a PR with an adjustment to this and various other fixes to issues I caused 😅

#188

[yoyoma2]

I should have tested the pre-release in an environment that better mimicked my deployment environment.

[mag37]

@vorezal

Definitely an oversight on my part here. I've started working on a PR with an adjustment to this and various other fixes to issues I caused 😅

#188

@yoyoma2

I should have tested the pre-release in an environment that better mimicked my deployment environment.

Cmon guys, don't beat yourself up - you're both doing great work here, I'm very grateful!

[cirrusflyer]

Agreed. Great piece of work here.