Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only inherit themes which are really needed #84

Open
alexxcons opened this issue Jun 2, 2024 · 0 comments
Open

Only inherit themes which are really needed #84

alexxcons opened this issue Jun 2, 2024 · 0 comments

Comments

@alexxcons
Copy link

Hi Obsidian team,

now that the related xdg merge request got merged and v0.18 of the spec got released, I am starting my mission to get the "Inherits" attribute right for popular icon-themes to prevent potentially missing icons 🙂

Currently Obsidian has:

Inherits=Ambiant-MATE,Mint-X,Faenza-Dark,KFaenza,gnome,hicolor

I wonder why Ambiant-MATE,Mint-X,Faenza-Dark,KFaenza and gnome are listed here ... is Obsidian lacking fd.org icons which need to be provided by these?

If there is no strong reason to keep them in the Inherits list, I would suggest dropping them.

If one/some of the other themes need to stay on the list for some reason, it makes sense to have a section in the README.md to explain packagers that the obsidian-icon-theme package should have a hard dependency on the other listed themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant