Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig_brackets failes correctly filter for feature given as string #51

Open
livhe opened this issue Sep 4, 2024 · 0 comments · May be fixed by #52
Open

sig_brackets failes correctly filter for feature given as string #51

livhe opened this issue Sep 4, 2024 · 0 comments · May be fixed by #52
Assignees
@livhe
Labels
bug Something isn't working

Comments

@livhe
Copy link
Collaborator

livhe commented Sep 4, 2024

When giving a single string to pipeline.sig_brackets as the feature parameter (as is allowed according to docs), the filtering is applied letter per letter and thus yields useless results, e.g. the significance brackets for all features.
@livhe livhe added the bug Something isn't working label Sep 4, 2024
@livhe livhe self-assigned this Sep 4, 2024
@livhe livhe linked a pull request Sep 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@livhe livhe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sig brackets function if feature is given as a string mad-lab-fau/BioPsyKit
1 participant
@livhe