Exit With Error If Push Fails

[DonovanDMC]

Currently, the jobs shows as successfully ran even if the push actually failed. This makes taking a quick look to see if a push succeeded impossible.

For instance, if the image does not exist yet:

denied: permission_denied: The requested installation does not exist.

or if the action cannot push to the specific package:

denied: permission_denied: write_package

both of these are failures, but the run exits as if everything went just fine

[macbre]

@DonovanDMC - thanks for a bug report.

Are you using the latest version of the push-to-ghcr action? I'm trying to reproduce that issue (see #27) and the action ends with the exit code 1 (hence breaking the process):

[DonovanDMC]

You're testing against a condition that returns an exit code, so of course it exits fine

https://github.com/DonovanDMC/Websites/blob/master/.github/workflows/publish-container.yml

I can very reliably reproduce this by pushing to a package that doesn't exist, or pushing to one that you only have read only access for.

The run completed as if everything went fine, despite the second to last line showing that the push failed

[kthy]

We just got bit by this as well:

▸ Run macbre/push-to-ghcr@master
▸ Run echo "Using $(docker -v)"
Using Docker version 24.0.9, build 2936816
▸ Logging into the GitHub Container registry (ghcr.io) ...
▸ Set commit tag and image name
▸ Building the Docker image: ghcr.io/utiligize/assetlife-api:latest from ./Dockerfile in . context ...
▸ Inspecting the image ...
▾ Pushing the Docker image to ghcr.io ...
  denied: installation not allowed to Write organization package
Notice: NOT pushing the Docker image to docker.io ... Provide 'docker_io_token' if needed.

The action completes as green.