Skip to content

Commit b48a0e9

Browse files
al42andmabraham
authored andcommitted
Fix conditional for skipping DomDecSpecialCasesTest
We require numPmeRanksRequested ≤ numPPRanksRequested in DD. Only occurs when running the test binary manually with non-default flags.
1 parent bddfe80 commit b48a0e9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/programs/mdrun/tests/domain_decomposition.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,9 @@ std::optional<std::string> reasonsTestIsInvalid(MdpFlavor mdpFlavor,
192192
errorReasons.appendIf(numRanks > 1 && separatePmeRankFlavor == SeparatePmeRankFlavor::None
193193
&& pmeFlavor == PmeFlavor::Gpu,
194194
"Cannot use GPU PME offload with multiple PME+PP ranks");
195-
errorReasons.appendIf(numRanks == 2 && separatePmeRankFlavor == SeparatePmeRankFlavor::Two,
196-
"Cannot use two separate PME ranks when there are only two ranks total");
195+
errorReasons.appendIf(
196+
numRanks < 4 && separatePmeRankFlavor == SeparatePmeRankFlavor::Two,
197+
"Cannot use two separate PME ranks when there are less than four ranks total");
197198
errorReasons.finishContext();
198199
if (errorReasons.isEmpty())
199200
{

0 commit comments

Comments
 (0)