Enhancement in Nexus Spec

[AdheipSingh]

In current master this is the nexus spec object supporting the following parameters.

type NexusSpec struct {
	Replicas int32 `json:"replicas"`
	Image string `json:"image,omitempty"`
	Resources corev1.ResourceRequirements `json:"resources,omitempty"`
	Persistence NexusPersistence `json:"persistence"`
	UseRedHatImage bool `json:"useRedHatImage"`
	Networking NexusNetworking `json:"networking,omitempty"`
}

I would like to suggest an enhancement to this spec following all the deployment parameters such as taints,tolerations, liveliness, affinity , pod disruption budgets to be added.
Ill raise a PR for this soon.

Possible to add this on Projects as ticket enhancement.

[ricardozanini]

Hi! Please feel free to send a PR so we can discuss this implementation.

I’d like to also understand the motivations behind this. Do you mind sharing some use cases? Will help me understanding your needs. :)

Many thanks for your contribution!

[AdheipSingh]

I want like to add the following in the deployment spec

1. NodeSelectors, Tolerations, Affinity - I want to deploy nexus on tainted nodes so that no other pod apart from nexus can run on node.
2. Security Context - Apart from admin, don't want other teams to exec and execute commands in the container.
3. Pod Disruption Budget - PDB is critical in case on node drains and upgrades would want certain no of pods up as always.
4. Some custom annotations, and labels would be good.

[ricardozanini]

Awesome! Go ahead and send a PR, but wait for one update I’ll be sending over next Monday that changes the way the Deployment equality is done.

Would be needed for those changes.

Thanks again for reporting this.

[ricardozanini]

Related: #29

@AdheipSingh you can now rebase your branch and send the PR :-)

[AdheipSingh]

@ricardozanini Sure by eow it should be finalized.

[Kaitou786]

@AdheipSingh are you planning to work on this issue?

[ricardozanini]

@Kaitou786 if you have the time, suggest a PR so we can discuss there and invite @AdheipSingh. Seems a long time, maybe he got busy with other work. :(

[Kaitou786]

@ricardozanini sure :-)