Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golint linter as part of hack/go-lint.sh #173

Open
Kaitou786 opened this issue Oct 7, 2020 · 0 comments
Open

Add golint linter as part of hack/go-lint.sh #173

Kaitou786 opened this issue Oct 7, 2020 · 0 comments
Labels
bug 🐛 Something isn't working good first issue Good for newcomers Hacktoberfest
Milestone

Comments

@Kaitou786
Copy link
Collaborator

Describe the bug
Currently we check our code with golangci-lint, which in itself catches most of the things, but having comments over exported function is not caught by it, it'll be nice to enable both the linters. Currently there are some warnings by this linter on the main branch

To Reproduce
Run: golint ./... | grep -v zz_generated #to ignore the auto-generated files

Expected behavior
No warnings

The existing warning should be removed and the lint should also be part of CI so we don't have any warnings from future

@Kaitou786 Kaitou786 added bug 🐛 Something isn't working good first issue Good for newcomers Hacktoberfest labels Oct 7, 2020
@ricardozanini ricardozanini added this to the v1.0.0 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants