fix: Support maison 2.0.0 #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10568469741Details
💛 - Coveralls |
|
Thank you for your contribution @cjwatson , the path we've followed at If that sounds good to you, the ideal path for me would be:
How do you see it? |
|
I add #260 to just limit the version of maison. |
|
@zhou13 's contribution to pin maison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #258
I didn't see a good way to test both alternatives directly in the test suite, and it seemed too aggressive to just require the new version (though I can do that if you prefer). However, I've at least tested manually with both old and new versions of
maison.