Renaming kde-plasma theme to KDE-Plasma breaks existing user configuration

[yan12125]

Expected Behavior

My favorite theme continues to work after upgrading from lxqt 1.0.0 to 1.1.0

Current Behavior

This line theme=kde-plasma in ~/.config/lxqt/lxqt.conf no longer works, and another theme is picked (ambiance in my case). I need to use theme=KDE-Plasma to bring my favorite theme back. (I believe most users use lxqt-config-appearance. Editing files directly is just my preference.)

Possible Solution

• Add a symlink kde-plasma -> KDE-Plasma?
• Migrate existing configurations automatically?

Steps to Reproduce (for bugs)

1. With LXQt 1.0.0, pick kde-plasma theme
2. Upgrading to 1.1.0

Context

Testing whether LXQt 1.1.0 explodes :)

Related: #68.

System Information

• Distribution & Version: Arch Linux latest
• Kernel: 5.15.34-1-lts
• Qt Version: 5.15.3+kde+r137-1
• lxqt-build-tools Version: 0.11.0-1
• libqtxdg Version: 3.9.0-1
• Package version: 1.1.0-1

(All LXQt packages are built locally using Arch Linux PKGBUILDs)

[stefonarch]

This is expected so users will explore other themes ;)
I think a symlink is the best solution, migration is an overkill IMO.

[tsujan]

migration is an overkill IMO.

I agree.

I think a symlink is the best solution

Will it work? I haven't tested.

[stefonarch]

Nope, realized after writing - users end up with both themes in lxqt-appearance.
Maybe just leaving a note about that? It's not a big hassle but yes, it shouldn't happen.

[yan12125]

Nope, realized after writing - users end up with both themes in lxqt-appearance.

Yep, I only noticed that after testing

Maybe just leaving a note about that? It's not a big hassle but yes, it shouldn't happen.

A note sounds good!

[tsujan]

A more fundamental solution can be case-insensitivity in the code that's responsible for reading and applying the key. In LXQt Appearance Configuration → LXQt Theme, the first letters are already capitalized. So, maybe, we should have considered case-insensitivity from start.

[stefonarch]

We could also revert the renaming. I just didn't think about existing config break.

[tsujan]

We could also revert the renaming.

Then, the same problem will happen for a few git users that have already upgraded LXQt ;)

I think case-sensitivity is a problem, that has been ignored so far. If the theme names are supposed to be case-sensitive, why are they capitalized in the GUI?

[stefonarch]

A PR for this (also in the single announcement)?

[tsujan]

Yes, that's good for now.

[tsujan]

BTW, KDE-Plasma theme has the same problem that I worked around in Kvantum theme in #64. The problem is in Qt's stylesheet support.

EDIT: I mean this:

[stefonarch]

So the first PR for 1.2.0 ;)

[tsujan]

→ lxqt/liblxqt#308 (logging out and in is needed).

[yan12125]

We could also revert the renaming. I just didn't think about existing config break.

Maybe this is not a bad option. Only a few users are affected by double renaming. Other users, who will likely upgrade from 1.0.0 to 1.1.1 or newer, will not be affected.

In the future, to address the name issue mentioned in #57, we may specify the name "KDE Plasma" in a file like /usr/share/lxqt/themes/kde-plasma/index.theme. By the way, the theme file can also be a basis towards translatable theme names (lxqt/lxqt#455). For example, we can follow a similar pattern to XDG icon themes:

# /usr/share/lxqt/themes/kde-plasma/index.theme
[LXQt Theme]
Name=KDE Plasma
Name[uk]=KDE Плазма

(the Ukraine translation is copied from https://kde.org/uk/)