Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side-effect, loading Sodium too early #86

Open
piotr-yuxuan opened this issue Apr 19, 2022 · 2 comments
Open

Side-effect, loading Sodium too early #86

piotr-yuxuan opened this issue Apr 19, 2022 · 2 comments

Comments

@piotr-yuxuan
Copy link
Contributor

Hello! Thanks very much for this great work. For some project I've been trying to setup CI jobs that runs on GitHub Actions, and I believe that caesium trying to load sodium when loading ns makes the job fails. See an example for caesium itself analysed by cljdoc (link).

What would you think about putting these forms in a function that gets called on runtime startup, and not at compile time? https://github.com/lvh/caesium/blob/master/src/caesium/binding.clj#L720-L725

Cheers,
Piotr

@lvh
Copy link
Owner

lvh commented Apr 22, 2022

Sure, that seems fine. Perhaps a delay?

@lvh
Copy link
Owner

lvh commented Apr 22, 2022

I guess I should rephrase: can you be more specific w.r.t "runtime startup"? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants