Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values are not applied #22

Open
kisvegabor opened this issue Oct 14, 2024 · 3 comments
Open

Default values are not applied #22

kisvegabor opened this issue Oct 14, 2024 · 3 comments
Assignees

Comments

@kisvegabor
Copy link
Member

Describe the bug
If the default option's value in the manifest is different from the default value in the file the value should be replaced nothing happens. The value needs to be changed and changed back in order to make it effective.

To Reproduce
These are now work arounded in the existing projects by choosing the defaults consistently. So to reproduce it move this line to the "value": 1 section.

Expected behavior
Allow having different defaults in the manifest and file it works on.

Desktop:

  • OS: Linux Mint 21.3
  • Browser: N/A
  • Version: v1.1.0

Additional context
None.

@kisvegabor
Copy link
Member Author

@coevin Is it fixed in v1.1.1?

@coevin
Copy link
Collaborator

coevin commented Oct 30, 2024

@kisvegabor

There appear to two issues:

  1. Previously it was necessary to change the default option displayed in the dropdown and then change it back again to process it. That issue was fixed in v1.1.1.

  2. The first value in the options array in the manifest is what becomes the selected option in the UI dropdown, and therefore that is the value that gets processed. "default": "true" in the manifest has no effect. Anything in the manifest with that flag that is not the first entry in the options array will not become the selected option in the UI dropdown. It is therefore not processed unless explicitly selected by the user.

@kisvegabor
Copy link
Member Author

Clear, thank you. I leave it open then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants