Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsortable item can be sorted in some cases #885

Open
theluanr opened this issue May 5, 2022 · 3 comments
Open

Unsortable item can be sorted in some cases #885

theluanr opened this issue May 5, 2022 · 3 comments

Comments

@theluanr
Copy link

theluanr commented May 5, 2022

Describe the bug
Unsortable item can be sorted in some cases.

To Reproduce
Steps to reproduce the behavior:
Way one:

  1. Drag a unsortable item to another unsortable item (no visual effect)
  2. Both of them can be sorted now

Way Two:
1.A sortable item with index [n], and a unsortable item with index [n+1]
2.Drag the sortable cross the unsortable item (change their index)
3.Repeat step2 (reset their index)
4. The unsortable item can be sorted now

Expected behavior
Make sure unsortable item can't be sorted.

Test Case
Please copy this codepen and create a working test case showing the experienced bug: https://codepen.io/pen/?template=GRoQRxo
Has tested, it exists.

System (please complete the following information):

  • OS: win10
  • Browser chrome 100.0.4896.60
  • Version v0.13.1

Additional context
None

@theluanr
Copy link
Author

theluanr commented May 5, 2022

Way Three:
1.A unsortable item with index [n], and a sortable item with index [m] (n>m)
2.Drag a unsortable item to a sortable item (no visual effect)
3.The unsortable item can be sorted now

@theluanr
Copy link
Author

theluanr commented May 5, 2022

It works on "items: ':not([unsortable item selector])'", not for "sortable('[[selector]]', 'disable')".
I suggest it need a new attribute which equivalent to [draggable="false"] when init, or block event when dragging a unsortable item.
Using "$('[selector]').attr('draggable', false);" to hack it temporary ...

@lukasoppermann
Copy link
Owner

If you can send a PR to fix this, that would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants