New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clash storing event listeners for 'dragenter' #515
Comments
The first occurence is lines 344-L370 _on(sortableElement, 'dragenter', (e) => {
// ... The second addEventListener(listItems.concat(sortableElement), 'dragenter', onDragOverEnter); To resolve this we need to do the following:
If I read it correctly, lines 344-L370 are only needed to fire the The difference between
@kaffarell do you see it like as well? This would mean we would need to separate the event in lines 580-598 as the sortenter event should only fire once. Best would be to create a function for the codes in lines 344-L370 as well and than call both functions for |
Two listeners are added for 'dragenter'.
One here
and the second here
The callback is stored using the event name
which causes one to overwrite the other.
Now only one callback can be retrieved for removal
A fix could be to remove this line altogether.
Dragging would still be caught by the 'dragover' event listener in the adjacent line. Is there a reason why we need both 'dragover' and 'dragenter'?
See issue #512 for background
The text was updated successfully, but these errors were encountered: