Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Add the reactive validations to the validation rules plugin #23

Open
DamienDoumer opened this issue Jun 2, 2022 · 6 comments

Comments

@DamienDoumer
Copy link

Using reactive UI, we could make the validation process of the validation rules plugin automatic, and even do validation based on other properties of the same ViewModel.

Features

  • Add a reactive validation rule mechanism based on the original validation rules plugin
  • Make a demo of how these reactive validation rules function on Xamarin.Forms and MAUI
DamienDoumer added a commit to DamienDoumer/ValidationRulesPlugin that referenced this issue Jun 2, 2022
- Added a reactive validation rule mechanism based on the original validation rules plugin
- Made a demo of how these reactive validation rules function on Xamarin.Forms and MAUI
@luismts
Copy link
Owner

luismts commented Jun 2, 2022

Hi @DamienDoumer,

Thanks for taking your time for this. I will check it out and test it this weekend and let you know.

@luismts luismts added enhancement New feature or request new feature and removed enhancement New feature or request labels Jun 2, 2022
@DamienDoumer
Copy link
Author

Hello, @luismts did you finally check my PR? don't hesitate to let me know if you have any questions regarding my PR.

@luismts
Copy link
Owner

luismts commented Jun 13, 2022

sorry, I forgot that.

@DamienDoumer
Copy link
Author

Ok,

@luismts
Copy link
Owner

luismts commented Jun 18, 2022

Can you explain a little more about the benefits of your PR?

As far as it goes ReactiveUI has its own validations and adding that workload just for a small profit is not entirely clear to me.

cc @DamienDoumer

@DamienDoumer
Copy link
Author

Hi @luismts
ReactiveUI has a validation mechanism, but it is not as flexible as what Validation Rules brings "In my Opinion". I've been using the Validation Rules approach to validating input since 2017, and in my projects, I combine it with reactive UI to validate automatically without having to raise validation when the property's value changes and I find it very handy. I ported my code to your library cause I thought some other people might find value in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants