Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: GEO Functions #292

Open
rsmck opened this issue Aug 4, 2023 · 5 comments
Open

Feature Request: GEO Functions #292

rsmck opened this issue Aug 4, 2023 · 5 comments
Labels

Comments

@rsmck
Copy link

rsmck commented Aug 4, 2023

It would be nice if the Medis UI could show geospatial sorted sets as lat/lon rather than just integer values, even better to perhaps render a pin on a map (but appreciate that's a much bigger UI change)

As a geospatial set is just stored internally as a standard sorted set within redis, I guess this would require some sort of implementation to support selecting how the set is interpreted.

@luin
Copy link
Owner

luin commented Aug 5, 2023

Will take a look. Thanks for the feature request!

@luin
Copy link
Owner

luin commented Aug 19, 2023

I made a first version of the GEO feature support:

CleanShot 2023-08-19 at 17 07 35@2x

After experimenting with the interface, I've found that I'm not particularly keen on displaying the latitude/longitude data and map in the sidebar. As an alternative, we can introduce a "Preview" menu item to the context menu that appears when a zset item is right-clicked. This would open a separate window to display the latitude/longitude data and map. Do you happen to have any suggestions, @rsmck?

@rsmck
Copy link
Author

rsmck commented Aug 21, 2023

That's great! I agree that it clutters the side bar and doesn't seem the right place for it, Preview in the context menu would be great, perhaps (if possible) also mimic the QuickLook behaviour in the OS so allow space bar to trigger that preview and if moving up/down the list using the arrow keys update the already open preview (QuickLook) window to the relevant key - much like browsing images in Finder?

@luin
Copy link
Owner

luin commented Aug 26, 2023

Thanks for the advice. I've explored the sidebar idea a little bit more and came out something like:

CleanShot 2023-08-26 at 11 00 00@2x

I'll think about it furthermore and maybe try out the preview idea.

@rsmck
Copy link
Author

rsmck commented Aug 28, 2023

This is great, thank you! :D

@luin luin added the feature label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants