From 5801583218e50bc00ab1b1515133469d6942e496 Mon Sep 17 00:00:00 2001
From: Ludek <13610612+ludeknovy@users.noreply.github.com>
Date: Mon, 8 Mar 2021 16:00:59 +0100
Subject: [PATCH] throughput analysis (#103)

---
 .../item-detail/item-detail.component.html    | 16 ++++++++++++--
 src/app/item-detail/item-detail.component.ts  | 21 +++++++++++++++----
 2 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/src/app/item-detail/item-detail.component.html b/src/app/item-detail/item-detail.component.html
index a22d9bde..8d6bc86d 100644
--- a/src/app/item-detail/item-detail.component.html
+++ b/src/app/item-detail/item-detail.component.html
@@ -87,7 +87,7 @@ <h6 class="card-title text-alizarin">Performance regression issue detected! <i c
 
       <div class="row">
         <div class="col">
-          <div class="card" [ngClass]="(perfAnalysis.onePerc.failed || perfAnalysis.variability.failed) ? 'performance-analysis-warning' : 'performance-analysis-success'">
+          <div class="card" [ngClass]="(perfAnalysis.onePerc.failed || perfAnalysis.variability.failed || perfAnalysis.throughputVariability.failed) ? 'performance-analysis-warning' : 'performance-analysis-success'">
             <div class="card-body">
               <h6 class="overview-body">Performance Analysis</h6>
               <div>
@@ -107,7 +107,7 @@ <h6 class="overview-body">Performance Analysis</h6>
               <div class="perf-analysis-check">
                 <div><i
                     [ngClass]="(perfAnalysis.variability.failed===true) ? 'fas fa-exclamation-triangle text-warning' : 'far fa-check-circle text-success'"></i>
-                  Steady performance</div>
+                  Steady response time performance</div>
                 <div *ngIf="perfAnalysis.variability.failed===true" class="perf-analaysis-desc text-secondary">
                   Increased variability between the fastest and the average response time was detected (up to {{perfAnalysis.variability.value}}x). The SUT might have been overloaded.
                 </div>
@@ -115,6 +115,18 @@ <h6 class="overview-body">Performance Analysis</h6>
                   The SUT was providing balanced response times across all labels.
                 </div>
               </div>
+
+              <div class="perf-analysis-check">
+                <div><i
+                    [ngClass]="(perfAnalysis.throughputVariability.failed===true) ? 'fas fa-exclamation-triangle text-warning' : 'far fa-check-circle text-success'"></i>
+                  Steady throughput performance</div>
+                <div *ngIf="perfAnalysis.throughputVariability.failed===true" class="perf-analaysis-desc text-secondary">
+                  Significant drops in throughput performance were detected (up to {{perfAnalysis.throughputVariability.value}}%). The SUT might have been overloaded.
+                </div>
+                <div *ngIf="perfAnalysis.throughputVariability.failed===false" class="perf-analaysis-desc text-secondary">
+                  The SUT was providing balanced throughput.
+                </div>
+              </div>
             </div>
           </div>
         </div>
diff --git a/src/app/item-detail/item-detail.component.ts b/src/app/item-detail/item-detail.component.ts
index cdbf01f6..4e002749 100644
--- a/src/app/item-detail/item-detail.component.ts
+++ b/src/app/item-detail/item-detail.component.ts
@@ -57,7 +57,7 @@ export class ItemDetailComponent implements OnInit {
   comparisonWarning = [];
   token: string;
   isAnonymous = false;
-  perfAnalysis = { variability: null, onePerc: null };
+  perfAnalysis = { variability: null, onePerc: null, throughputVariability: null };
 
   constructor(
     private route: ActivatedRoute,
@@ -116,7 +116,8 @@ export class ItemDetailComponent implements OnInit {
     this.throughputChartOptions = { ...commonGraphSettings('hits/s'), series: [...throughput, ...threadLine], ...logScaleButton };
     this.overallChartOptions = {
       ...overallChartSettings('ms'), series: [
-        threadLine, overallTimeResponse, throughputLine, errorLine],
+        threadLine, overallTimeResponse, throughputLine, errorLine,
+      ],
     };
   }
 
@@ -248,7 +249,7 @@ export class ItemDetailComponent implements OnInit {
   private performanceAnalaysis() {
     const output = [];
     this.itemData.statistics.forEach(_ => {
-      const variability =  this.roundNumberTwoDecimals(_.avgResponseTime / _.minResponseTime);
+      const variability = this.roundNumberTwoDecimals(_.avgResponseTime / _.minResponseTime);
       const onePerc = this.roundNumberTwoDecimals(_.n9 / _.avgResponseTime);
       output.push({
         variability,
@@ -262,11 +263,18 @@ export class ItemDetailComponent implements OnInit {
     const variabilitySorted = output.sort((a, b) => b.variablity - a.variablity);
     const onePercSorted = output.sort((a, b) => b.onePerc - a.onePerc);
 
+    const { overallThroughput, threads } = this.itemData.plot;
+    const { maxVu, throughput } = this.itemData.overview;
+    const rampUpIndex = threads.map(_ => _[1]).indexOf(maxVu);
+
+    const minThroughput = Math.min(...overallThroughput.data.slice(rampUpIndex, -2).map(_ => _[1]));
+    const throughputVariability = 100 - this.roundNumberTwoDecimals((minThroughput / throughput) * 100);
+
     this.perfAnalysis = {
       variability: {
         value: variabilitySorted[0].variability,
         avgResponseTime: variabilitySorted[0].avgResponseTime,
-        minResponseTime:  variabilitySorted[0].minResponseTime,
+        minResponseTime: variabilitySorted[0].minResponseTime,
         failed: variabilitySorted[0].variability > 2.5
       },
       onePerc: {
@@ -274,7 +282,12 @@ export class ItemDetailComponent implements OnInit {
         avgResponseTime: onePercSorted[0].onePerc.avgResponseTime,
         failed: onePercSorted[0].onePerc > 2.5
       },
+      throughputVariability: {
+        value: throughputVariability,
+        failed: throughputVariability > 20,
+      }
     };
+
   }
 
   bytesToMbps(bytes) {