Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript tooling #11

Open
benjie opened this issue Jul 20, 2020 · 2 comments
Open

JavaScript tooling #11

benjie opened this issue Jul 20, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@benjie
Copy link

benjie commented Jul 20, 2020

Hey @lucmos thanks for writing this package, it's just what I was looking for!

This was my first dabble with plasma, so I spent some time setting up my regular JS tooling for it (TypeScript, ESLint, prettier, etc) and reformatting the code slightly. I've not opened my changes as a PR because they were really just for me, but if you're interested in a PR I'd be happy to clean them up and send one through. If you're not interested (which I'd completely understand! who needs a build-step for something simple like this?!) feel free to just close this issue.

My fork is here: https://github.com/benjie/UltrawideWindows

The main code you'd care about is in src/main.ts: https://github.com/benjie/UltrawideWindows/blob/13152e8bf2450556d38ea81804eef746c22299fe/src/main.ts#L153-L598

(Don't worry about the type definitions above line 153, they'll be factored out at some point.)

Cheers!

PS: do you know, where's the canonical documentation of API this JS code consumes?

@lucmos
Copy link
Owner

lucmos commented Jul 22, 2020

@benjie thank you for the refactoring!
Actually this mini script has been my first and only experience with Javascript, so I'm not experienced in the JS tooling and ecosystem.

At the moment I'm a bit busy with other stuff, in a few weeks I'll read everything at least to learn some new useful stuff :)


If I remember correctly, I looked up the docs here and took inspiration from another script I found online to understand how to move windows.

@benjie
Copy link
Author

benjie commented Jul 22, 2020

Thanks for sharing that link. Take all the time you need, I just raised this issue for your interest 👍

@lucmos lucmos added the enhancement New feature or request label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants