[Bug]: switch to hash @node-rs/argon2 breaks sveltekit production builds #1567

vhochstein · 2024-05-12T13:55:10Z

Package

lucia

Describe the bug

Latest versions of Lucia are relying upon: import { hash } from "@node-rs/argon2";
That one is breaking npm run build for sveltekit projects.
Please see error below.
node: v20.11.1

/Users/volkerhochstein/projects/node/magic-pull/node_modules/@node-rs/argon2-android-arm-eabi/argon2.android-arm-eabi.node error during build: RollupError: Unexpected character '\u{7f}' at getRollupError (file:///Users/volkerhochstein/projects/node/magic-pull/node_modules/rollup/dist/es/shared/parseAst.js:380:41) at ParseError.initialise (file:///Users/volkerhochstein/projects/node/magic-pull/node_modules/rollup/dist/es/shared/node-entry.js:11172:28) at convertNode (file:///Users/volkerhochstein/projects/node/magic-pull/node_modules/rollup/dist/es/shared/node-entry.js:12914:1

Looks like there is already a corresponding ticket open in node-rs/argon2,
napi-rs/node-rs#816

If I use "old style" to create hash and verification eg:
return await new Argon2id().hash(password);
and remove import for node-rs/argon2 prod build npm task is working

building in dev mode is working without any issue for both hashing solutions

What do you suggest to do, currently I do not know how to work around this ?

Thanks a lot for your support

The text was updated successfully, but these errors were encountered:

vhochstein · 2024-05-14T06:55:07Z

Tried now other node versions eg. node 18
and tried other machines to build.
But always the same issue.

Any help would be greatly appreciated.

pilcrowOnPaper · 2024-05-14T08:33:59Z

Is it an issue with Lucia or Oslo?

vhochstein · 2024-05-14T14:36:05Z

Not sure..
I ve just tried it with your example project: https://github.com/lucia-auth/examples/tree/main/sveltekit/username-and-password

if you install: npm i -D @sveltejs/adapter-node
adjust svelteConfig to adapter-node (just changing import)

switch hash algorithm to:
await hash(password, {
// recommended minimum parameters
memoryCost: 19456,
timeCost: 2,
outputLen: 32,
parallelism: 1
});

npm run build

I am getting same error

chaseweaver · 2024-05-14T14:54:14Z

Also running into this issue for what it's worth, but even running locally doesn't work on my end. Currently looking into a work around

vhochstein · 2024-05-14T15:54:43Z

I ve made a mistake in my own project..., let me correct my comment:
If I switch to oslo Argon hash, I can build for production, so same result as for example project.

so at least I have a workaround for the moment.

pilcrowOnPaper · 2024-05-14T23:28:26Z

Ah so you're using the adapter-node. Is Oslo/Argon installed as a dev dependency?

vhochstein · 2024-05-16T08:10:50Z

Argon is neither listed as dev nor "standard" dependency.
oslo is listed as "standard" dependency.
Simlar to: https://github.com/lucia-auth/examples/tree/main/sveltekit/username-and-password

pilcrowOnPaper · 2024-05-16T08:34:02Z

I'm not really following here. Is it an issue with Oslo or napi-rs? Lucia doesn't have a dependency on the latter

vhochstein · 2024-05-16T08:51:14Z

Its about these imports given in code example on the following page:
https://lucia-auth.com/tutorials/username-and-password/sveltekit
import { hash } from "@node-rs/argon2"; import { verify } from "@node-rs/argon2";

LargatSeif · 2024-05-25T11:28:14Z

[sveltekit]

having same issue here is the errors that i'm receiving :

the first : @node-rs/argon2-darwin-x64

✘ [ERROR] No loader is configured for ".node" files: node_modules/.pnpm/@[email protected]/node_modules/@node-rs/argon2-darwin-x64/argon2.darwin-x64.node

    node_modules/.pnpm/@[email protected]/node_modules/@node-rs/argon2/index.js:159:36:
      159 │             nativeBinding = require('@node-rs/argon2-darwin-x64')

the second : @node-rs/bcrypt-darwin-x64

✘ [ERROR] No loader is configured for ".node" files: node_modules/.pnpm/@[email protected]/node_modules/@node-rs/bcrypt-darwin-x64/bcrypt.darwin-x64.node

    node_modules/.pnpm/@[email protected]/node_modules/@node-rs/bcrypt/binding.js:153:36:
      153 │             nativeBinding = require('@node-rs/bcrypt-darwin-x64')
          ╵

chaseweaver · 2024-05-25T14:11:44Z

[sveltekit]

having same issue here is the errors that i'm receiving :

the first : @node-rs/argon2-darwin-x64

✘ [ERROR] No loader is configured for ".node" files: node_modules/.pnpm/@[email protected]/node_modules/@node-rs/argon2-darwin-x64/argon2.darwin-x64.node

    node_modules/.pnpm/@[email protected]/node_modules/@node-rs/argon2/index.js:159:36:
      159 │             nativeBinding = require('@node-rs/argon2-darwin-x64')

the second : @node-rs/bcrypt-darwin-x64

✘ [ERROR] No loader is configured for ".node" files: node_modules/.pnpm/@[email protected]/node_modules/@node-rs/bcrypt-darwin-x64/bcrypt.darwin-x64.node

    node_modules/.pnpm/@[email protected]/node_modules/@node-rs/bcrypt/binding.js:153:36:
      153 │             nativeBinding = require('@node-rs/bcrypt-darwin-x64')
          ╵

@LargatSeif Try adding this to your optimizeDeps.exclude in your vite.config.ts and see if that fixes it

optimizeDeps: {
    exclude: ['@node-rs/argon2', '@node-rs/bcrypt']
},

LargatSeif · 2024-05-25T22:00:59Z

[sveltekit]

having same issue here is the errors that i'm receiving :

the first : @node-rs/argon2-darwin-x64

✘ [ERROR] No loader is configured for ".node" files: node_modules/.pnpm/@[email protected]/node_modules/@node-rs/argon2-darwin-x64/argon2.darwin-x64.node

    node_modules/.pnpm/@[email protected]/node_modules/@node-rs/argon2/index.js:159:36:
      159 │             nativeBinding = require('@node-rs/argon2-darwin-x64')

the second : @node-rs/bcrypt-darwin-x64

✘ [ERROR] No loader is configured for ".node" files: node_modules/.pnpm/@[email protected]/node_modules/@node-rs/bcrypt-darwin-x64/bcrypt.darwin-x64.node

    node_modules/.pnpm/@[email protected]/node_modules/@node-rs/bcrypt/binding.js:153:36:
      153 │             nativeBinding = require('@node-rs/bcrypt-darwin-x64')
          ╵

@LargatSeif Try adding this to your optimizeDeps.exclude in your vite.config.ts and see if that fixes it

optimizeDeps: {
    exclude: ['@node-rs/argon2', '@node-rs/bcrypt']
},

this worked thanks 🙏

pilcrowOnPaper · 2024-06-08T02:38:25Z

Is this a bug or just something we need to add to the docs?

chaseweaver · 2024-06-09T02:52:57Z

Something funky must have happened with one of the @node-rs packages at some point but is fixed now. It appears as though those packages are no longer required to be in optimizeDeps (at least the few projects I work on no longer seem to need it). I cannot replicate the original issue any longer either.

Probably safe to call it "not a bug" unless @vhochstein is still having issues.

holahoon · 2024-06-10T19:28:38Z

I get a similar error when using it in Next.js. I'm sure this is related to node-rs/argon2 as I got a similar error when using the below code:

import { hash } from "@node-rs/argon2";
...
const passwordHash = await hash(password, {
    // recommended minimum parameters
    memoryCost: 19456,
    timeCost: 2,
    outputLen: 32,
    parallelism: 1
});

When I following the Next.js example with oslo/password:

import { Argon2id } from "oslo/password";
...
// hasing pw
const hashedPassword = await new Argon2id().hash(password);

// verifying pw
const validPassword = await new Argon2id().verify(existingUser.password, password);

I get this error

btw, huge fan of your library!

njanke96 · 2024-06-14T23:27:16Z

The "Unexpected character" issue seems to be an issue with bundlers not handling .node files, see vitejs/vite#14289. Some users in that thread have found workarounds

EDIT: I fixed it in SvelteKit by explicitly adding @node-rs/argon2 to "dependencies" of my SvelteKit app (even though it's the dependancy of a library package in my monorepo) and adding @node-rs/argon2 to rollupOptions.external in my Vite config. I can now use @node-rs/argon2 (or oslo/password) server-side in my app.

dBianchii · 2024-07-03T15:40:48Z

Hi, I am getting this error, but for Next.JS:

│   ▲ Next.js 14.2.4
│ 
│    Creating an optimized production build ...
│ Failed to compile.
│ 
│ ../../packages/api/node_modules/@node-rs/argon2-linux-x64-gnu/argon2.linux-x64-gnu.node
│ Module parse failed: Unexpected character '' (1:0)
│ You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
│ (Source code omitted for this binary file)

NOTE: as per the documentation on lucia, I have already added

experimental: {
    serverComponentsExternalPackages: ["@node-rs/argon2"],
  },

to my next.config.js file, but no luck

dBianchii · 2024-07-03T16:57:58Z

OOOKK, Sooo...

I discovered that the problem was that I was using @node-rs/argon2 in a separate package from my monorepo, that was being used by my Next.JS app. (@acme/api package from this monorepo starter: https://github.com/noxify/t3-turbo-lucia)

So, since @node-rs/argon2 wasn't a direct dependency, I guess that serverComponentsExternalPackages: ["@node-rs/argon2"], config for nextjs was being pretty much ignored.

Solution: I installed @node-rs/argon2 directly on my next.js app, so it appears on its package.json. Then, the serverComponentsExternalPackages works correctly. If you are on a monorepo, make sure this package is installed directly, even if it is only being undirectly being used by next.js

vhochstein added the bug Something ain't right... label May 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: switch to hash @node-rs/argon2 breaks sveltekit production builds #1567

[Bug]: switch to hash @node-rs/argon2 breaks sveltekit production builds #1567

vhochstein commented May 12, 2024 •

edited

Loading

vhochstein commented May 14, 2024

pilcrowOnPaper commented May 14, 2024

vhochstein commented May 14, 2024 •

edited

Loading

chaseweaver commented May 14, 2024

vhochstein commented May 14, 2024

pilcrowOnPaper commented May 14, 2024

vhochstein commented May 16, 2024

pilcrowOnPaper commented May 16, 2024

vhochstein commented May 16, 2024

LargatSeif commented May 25, 2024 •

edited

Loading

chaseweaver commented May 25, 2024 •

edited

Loading

LargatSeif commented May 25, 2024

pilcrowOnPaper commented Jun 8, 2024

chaseweaver commented Jun 9, 2024 •

edited

Loading

holahoon commented Jun 10, 2024 •

edited

Loading

njanke96 commented Jun 14, 2024 •

edited

Loading

dBianchii commented Jul 3, 2024 •

edited

Loading

dBianchii commented Jul 3, 2024 •

edited

Loading

[Bug]: switch to hash @node-rs/argon2 breaks sveltekit production builds #1567

[Bug]: switch to hash @node-rs/argon2 breaks sveltekit production builds #1567

Comments

vhochstein commented May 12, 2024 • edited Loading

Package

Describe the bug

vhochstein commented May 14, 2024

pilcrowOnPaper commented May 14, 2024

vhochstein commented May 14, 2024 • edited Loading

chaseweaver commented May 14, 2024

vhochstein commented May 14, 2024

pilcrowOnPaper commented May 14, 2024

vhochstein commented May 16, 2024

pilcrowOnPaper commented May 16, 2024

vhochstein commented May 16, 2024

LargatSeif commented May 25, 2024 • edited Loading

chaseweaver commented May 25, 2024 • edited Loading

LargatSeif commented May 25, 2024

pilcrowOnPaper commented Jun 8, 2024

chaseweaver commented Jun 9, 2024 • edited Loading

holahoon commented Jun 10, 2024 • edited Loading

njanke96 commented Jun 14, 2024 • edited Loading

dBianchii commented Jul 3, 2024 • edited Loading

dBianchii commented Jul 3, 2024 • edited Loading

vhochstein commented May 12, 2024 •

edited

Loading

vhochstein commented May 14, 2024 •

edited

Loading

LargatSeif commented May 25, 2024 •

edited

Loading

chaseweaver commented May 25, 2024 •

edited

Loading

chaseweaver commented Jun 9, 2024 •

edited

Loading

holahoon commented Jun 10, 2024 •

edited

Loading

njanke96 commented Jun 14, 2024 •

edited

Loading

dBianchii commented Jul 3, 2024 •

edited

Loading

dBianchii commented Jul 3, 2024 •

edited

Loading