Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Select default page and module templates #42

Open
lucabriguglia opened this issue Jul 10, 2017 · 12 comments
Open

Select default page and module templates #42

lucabriguglia opened this issue Jul 10, 2017 · 12 comments
Assignees

Comments

@lucabriguglia
Copy link
Owner

lucabriguglia commented Jul 10, 2017

DRAFT

Implementation notes:

Page Templates

  • Create query GetPageTemplates in Weapsy.Reporting.Themes
  • Create handler GetPageTemplatesHandler in Weapsy.Data.Reporting
  • Add GetPageTemplates action in Weapsy.Api.ThemeController

Module Templates:

  • Create query GetModuleTemplates in Weapsy.Reporting.Themes
  • Create handler GetModuleTemplatesHandler in Weapsy.Data.Reporting
  • Add GetModuleTemplates action in Weapsy.Api.ThemeController

Theme

  • Add IsPageTemplateValid method to IThemeRules
  • Add IsModuleTemplateValid method to IThemeRules

Site Settings

  • Add page template validation to UpdateSiteDetailsValidator
  • Add module template validation to UpdateSiteDetailsValidator

Site Settings UI

  • Add page templates dropdown (populated based on selected theme)
  • Add module templates dropdown (populated based on the selected theme)

...

@araqiel2552
Copy link
Contributor

If I have the time, I work on it this week.

@lucabriguglia lucabriguglia self-assigned this Jul 10, 2017
@lucabriguglia
Copy link
Owner Author

Thanks but I'm still not sure about the implementation, there are no db entities for the templates yet.
And I'm not even sure if it's the best way to handle it.
We could just read the available page and module templates from the theme folder.

@lucabriguglia
Copy link
Owner Author

lucabriguglia commented Jul 10, 2017

I keep this as assigned to myself at the moment.

@araqiel2552
Copy link
Contributor

Okay :)

@lucabriguglia
Copy link
Owner Author

@adanb007, @araqieldev let's decide what is the best approach for selecting page and module templates :-)

@lucabriguglia
Copy link
Owner Author

Definitely using the database.

@adanb007
Copy link
Contributor

I agree, using the DB to manage the templates.

@adanb007
Copy link
Contributor

Please let me know if we reach agreement and who will be doing the work!

@lucabriguglia
Copy link
Owner Author

lucabriguglia commented Jul 13, 2017

Absolutely, we could even split the work.
In the meantime I probably need to refactor the domain part as at the moment the templates have a separate aggregate but it's probably better to add them as entities in the theme aggregate.

@adanb007
Copy link
Contributor

Understood Luca. I am the newbie here, so, I will await instructions :)

@lucabriguglia
Copy link
Owner Author

I decided to keep the templates in a separate aggregate and add a ThemeId property.
I'm going to amend the validation of template creation by checking that the linked theme exists.
Once finished that part I'll create separate tasks to address the selection of the default templates at site and page levels.

@adanb007
Copy link
Contributor

Understood!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants