Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: LuaRocks 3.11.0 bug - win32-x86_64 (fs_use_modules = true) (binary) - when installing a package that transitively depends on LuaFileSystem #1656

Open
mrcjkb opened this issue Mar 28, 2024 · 3 comments
Labels

Comments

@mrcjkb
Copy link

mrcjkb commented Mar 28, 2024

Please fill out the following:

  • Platform:

    • win32-x86_64
  • LuaRocks version:

    • 3.11.0
  • Configuration file:

    • Default config
  • LuaRocks output from when the issue occurred:

https://gist.github.com/mrcjkb/ce8dfe66b4eff37092ca5bd396b193f9

(includes both verbose and non-verbose output)

  • Description:
    • Run on a Windows GitHub runner with this workflow file.
    • Trying to install a package, which has a build dependency, luarocks-build-treesitter-parser, which depends on LuaFileSystem.
    • For some reason, it seems to be looking for a lua 5.4 header, even though it's configured to install with lua 5.1;
      see this log line: Build error: Lua header lua.h found at D:/a/rocks-binaries-dev/rocks-binaries-dev/.lua/include does not match Lua version 5.4.
@hishamhm
Copy link
Member

This is because the LuaRocks binary itself is built with Lua 5.4, so the build dependency refers to the version LuaRocks itself is running in, not the Lua version that LuaRocks is targeting.

@hishamhm
Copy link
Member

hishamhm commented Mar 28, 2024

So, to clarify, I do not consider this to be a bug per se. But I do realize this makes the CI setup awkward, especially on Windows where multiversion packages are not common. I don't have an immediate suggestion on how to best deal with this... this is worth thinking about.

@mrcjkb
Copy link
Author

mrcjkb commented Mar 28, 2024

Ah, thanks for the clarification 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants