Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ltertools] Develop expand_key Function #41

Closed
3 tasks done
njlyon0 opened this issue Feb 20, 2025 · 4 comments
Closed
3 tasks done

[ltertools] Develop expand_key Function #41

njlyon0 opened this issue Feb 20, 2025 · 4 comments
Assignees
Labels
network-office LTER Network Office (LNO) tasks working-group Synthesis Working Group (SWG) tasks

Comments

@njlyon0
Copy link
Member

njlyon0 commented Feb 20, 2025

Summary

Both CAGED and Resilience (the two working groups in this cohort) have reminded me that data discovery is an iterative process and that the harmonize and begin_key functions currently in the ltertools R package don't really reflect this. There would be value in a function that creates the first two columns of the data key but only for datasets not already in the harmonized data file.

Starting Tasks

  • Draft expand_key function
  • Do needed tweaks for roxygen format
  • Consider releasing new version to CRAN

Useful links

@njlyon0 njlyon0 added network-office LTER Network Office (LNO) tasks working-group Synthesis Working Group (SWG) tasks labels Feb 20, 2025
@njlyon0 njlyon0 self-assigned this Feb 20, 2025
@njlyon0 njlyon0 moved this to Back Burner in Scientific Computing Tasks Feb 20, 2025
@njlyon0 njlyon0 moved this from Back Burner to Active Progress in Scientific Computing Tasks Feb 20, 2025
@njlyon0
Copy link
Member Author

njlyon0 commented Feb 20, 2025

This was specifically prompted by #40 (though also partially inspired by #34 )

@njlyon0
Copy link
Member Author

njlyon0 commented Feb 20, 2025

New Function Implemented

expand_key is now officially part of ltertools (at least in the GitHub version). I also added unit tests and added it to the vignette, NEWS, and README files (should have been in my first pass of sub-tasks but I forgot to include them).

I'm going to consider overnight whether it's worth another release to CRAN because this function is the only change from the prior version so in some ways it feels premature even if it would make it (marginally) easier to access this function

@njlyon0
Copy link
Member Author

njlyon0 commented Feb 21, 2025

Releasing New Version to CRAN

It's a small change from the prior version but I think the ease of installation for a formal CRAN update relative to using the GitHub / dev version is worth the release process. Just incremented from 1.1.0 to 1.2.0 and submitted to CRAN so hopefully they get that up into the official package space soon (and don't find any errors I missed)

New Sub-Tasks

  • Await feedback / decision from CRAN reviewer(s)
    • Implement feedback (if any) and resubmit to CRAN
  • After acceptance, create a new GitHub release for v1.2.0
  • Then update DESCRIPTION and NEWS to new development version

@njlyon0
Copy link
Member Author

njlyon0 commented Feb 21, 2025

v1.2.0 on CRAN!

Lightning fast response from CRAN reviewer and 1.2.0 is now up on CRAN. Just made the release on the GitHub side of things (see here). Just incremented the package documentation to version 1.2.0.900

@njlyon0 njlyon0 closed this as completed Feb 21, 2025
@github-project-automation github-project-automation bot moved this from Active Progress to Done in Scientific Computing Tasks Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network-office LTER Network Office (LNO) tasks working-group Synthesis Working Group (SWG) tasks
Projects
Development

No branches or pull requests

1 participant