Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager tells "ComfyUI has been sucessfully updated", even if the update fails. #1374

Closed
schoenid opened this issue Dec 26, 2024 · 1 comment

Comments

@schoenid
Copy link

The problem is, the update has been interrupted, because I've used a symbolic link for the output location. And there is no message about, just the message in the manager "ComfyUI has been sucessfully updated", which is not true, because the update has been interrupted ... I found it by observing another command, using pip in the terminal, which gave me a hint "aborted".
image

In the console I could see: ### ComfyUI Version: v0.2.2 | Released on '2024-09-05' before and after the update.
So the message is a lie!

The actual version: ### ComfyUI Version: v0.3.9-26-g19a64d62 | Released on '2024-12-25'

After removing the symbolic link the update runs trough and afterwards the console shows the correct version.
The manager tells me too: "ComfyUI has been sucessfully updated". This time its true.

What I expect is, the message should tell ComfyUI update has been aborted, if not successful.

Well I think, the easiest way would be, to compare version numbers before and after update trough the manager.
Then decide what to display, according to differences in the version number.

@ltdrdata
Copy link
Owner

The current implementation has some issues with update messages.

This will be improved in ComfyUI-Manager V3, so please wait a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants