Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible release clause will bypass downgrade_blacklist #1301

Closed
sko00o opened this issue Dec 5, 2024 · 5 comments
Closed

Compatible release clause will bypass downgrade_blacklist #1301

sko00o opened this issue Dec 5, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@sko00o
Copy link

sko00o commented Dec 5, 2024

I noticed some custom_nodes using ~= in requirements.txt .

It will make downgrade_blacklist not work.

How to reproduce this

  1. set diffusers in downgrade_blacklist
# ComfyUI/custom_nodes/ComfyUI-Manager/config.ini
[default]
# ...
downgrade_blacklist = diffusers
  1. install diffusers in venv
$ pip install diffusers==0.27.2
$ pip list | grep diffusers
diffusers                         0.27.2
  1. restart ComfyUI

  2. Install custom_nodes StableZero123-comfyui

The requirements.txt in this repo has this line diffusers~=0.21.4

  1. check diffusers version again
$ pip list | grep diffusers
diffusers                         0.21.4
@ltdrdata
Copy link
Owner

ltdrdata commented Dec 5, 2024

I cannot reproduce that issue.
Is your ComfyUI up to date?

@sko00o
Copy link
Author

sko00o commented Dec 6, 2024

Is your ComfyUI up to date?

Yes, I'm using the latest ComfyUI. And the issue is not related to ComfyUI.


Sorry for missing one step in bug reproduction. I should install a higher version diffusers in Step 2.
Considering the ComfyUI does not rely on diffusers. I simply use pip install to mock some custom nodes installation behavior.

For demonstration, I built a docker image with latest ComfyUI and ComfyUI-Manager installed. (https://github.com/sko00o/playground/tree/main/comfyui)

Open this repo in Github Codespace, and follow the steps:

# 1. launch comfyui and downgrade_blacklist will be set automatic
sudo bash comfyui/run.sh

# 2. install diffusers
pip install diffusers==0.27.2
pip list | grep diffusers
# diffusers                 0.27.2

# 3. open WebUI to install `StableZero123-comfyui` by ComfyUI-Manager

# 4. check diffusers version again
pip list | grep diffusers
# diffusers                 0.21.4

@sko00o
Copy link
Author

sko00o commented Dec 10, 2024

PTAL @ltdrdata

@ltdrdata
Copy link
Owner

confirmed the issue.

@ltdrdata
Copy link
Owner

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants