Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Fix LTP tests for sync_file_range02 and fdatasync03 #813

Open
hukoyu opened this issue Aug 20, 2020 · 1 comment · May be fixed by lsds/ltp#75
Open

[Test] Fix LTP tests for sync_file_range02 and fdatasync03 #813

hukoyu opened this issue Aug 20, 2020 · 1 comment · May be fixed by lsds/ltp#75
Assignees
@hukoyu
Labels
p2 Important but non-urgent priority

Comments

@hukoyu
Copy link
Collaborator

hukoyu commented Aug 20, 2020

Even if the two tests that I pointed out above sometimes pass, they are not implemented correctly. Given that, they are not testing anything useful.

  • The test sync_file_range02 mounts an already mounted block device again.
  • The test fdatasync03 tries to unmount a block device under an incorrect path.
  • The enclave config mounts /dev/vdb under /data but this is not the path that the tests assume, and they are still trying to do their own mounting and unmounting.

@prp only these two tests have problem right? Also if you can provide more info to help solution that will be awesome.
@hukoyu hukoyu self-assigned this Aug 20, 2020
@hukoyu hukoyu added the p2 Important but non-urgent priority label Aug 20, 2020
@github-actions github-actions bot added the needs-triage Bug does not yet have a priority assigned label Aug 20, 2020
@hukoyu
Copy link
Collaborator Author

hukoyu commented Aug 20, 2020

Disabled fdatasync03 and sync_file_range02 LTP tests for now in PR #812

@hukoyu hukoyu linked a pull request Aug 20, 2020 that will close this issue
Open
@bodzhang bodzhang added this to Needs triage in Issue triage via automation Aug 21, 2020
@bodzhang bodzhang moved this from Needs triage to Proposed p2 in Issue triage Aug 21, 2020
@bodzhang bodzhang removed the needs-triage Bug does not yet have a priority assigned label Aug 25, 2020
@bodzhang bodzhang removed this from Proposed p2 in Issue triage Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hukoyu hukoyu

Labels
p2 Important but non-urgent priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 2 tests about mount/umount lsds/ltp
2 participants
@bodzhang @hukoyu