Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getenv calls before libc startup #780

Open
vtikoo opened this issue Aug 13, 2020 · 0 comments · May be fixed by #806
Open

Remove getenv calls before libc startup #780

vtikoo opened this issue Aug 13, 2020 · 0 comments · May be fixed by #806
Assignees
@wintersteiger
Labels
p1 Medium priority
Projects
Clean up layering

Comments

@vtikoo
Copy link
Contributor

vtikoo commented Aug 13, 2020

lkl_start_init is using getenv fairly early in the initialization sequence. Which is requiring an early call to __init_libc.

According to @davidchisnall -
When we parse the environment variables from the config file, we should pull the SGX-LKL ones into globals and skip them, then we wouldn't need that extra complexity here.
From - lsds/sgx-lkl-musl#18 (comment)
@github-actions github-actions bot added the needs-triage Bug does not yet have a priority assigned label Aug 13, 2020
@davidchisnall davidchisnall added this to Remove musl dependencies from enclave / lkl init in Clean up layering Aug 17, 2020
@bodzhang bodzhang added this to Needs triage in Issue triage via automation Aug 17, 2020
@paulcallen paulcallen moved this from Needs triage to Proposed p1 in Issue triage Aug 17, 2020
@wintersteiger wintersteiger linked a pull request Aug 19, 2020 that will close this issue
Open
@bodzhang bodzhang added p1 Medium priority and removed needs-triage Bug does not yet have a priority assigned labels Aug 21, 2020
@bodzhang bodzhang removed this from Proposed p1 in Issue triage Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wintersteiger wintersteiger

Labels
p1 Medium priority
Projects
Clean up layering
  
Remove musl dependencies from enclave...
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add proper tracing options, remove getenv calls from enclave code. lsds/sgx-lkl
3 participants
@wintersteiger @vtikoo @bodzhang