-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins/notable): possible issues #1157
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #1148
Originally posted by jayvdb July 22, 2022
For the notable plugin, I set
debug: true
andplugin_notable_types: commit, issue, pull_request
, and obviously haveindepth
enabled, and now I am seeing quite a few of the following in the logRun: https://github.com/jayvdb/jayvdb/runs/7468279468?check_suite_focus=true
I don't have any commits in that repo, but I did create an issue: https://github.com/pdm-project/pdm/issues/created_by/jayvdb
pdm now appears in my svg jayvdb/jayvdb@01ec971 without any of the numerical scores inside its circle.
So I am guessing that
plugin_notable_types
ofissue
&pull_request
are incompatible withindepth
at the moment, unless there was a commit also in the repo.But the problem is a bit more nuanced than that, as I only have a rejected issue in TheLartians/ModernCppStarter#131, and only an unmerged closed PR in ansible/ansible-lint#2196 - both repos that were "successfully processed".
The text was updated successfully, but these errors were encountered: