Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 'Select' Element does not apply custom theme color to label #812

Closed
1 task done
placidic opened this issue Apr 17, 2024 · 4 comments
Closed
1 task done

[Bug]: 'Select' Element does not apply custom theme color to label #812

placidic opened this issue Apr 17, 2024 · 4 comments
Assignees

Comments

@placidic
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently, theme colors defined within a custom theme do not get applied to the Select Component Element.
Theme preview showing no update to the Select label

Screenshot 2024-04-17 083944
Screenshot 2024-04-17 084016

Expected Behavior

It is expected that the label element of the Select component, matches the predefined text color defined in the custom theme.

Steps to reproduce

  1. Create a Theme with custom text color.
  2. Preview Theme and observe preview

Environment

app.lowcoder.cloud - Verwion 2.3.1

Additional Information

No response

@placidic placidic changed the title [Bug]: 'Select' Element does not apply custom theme color to label and no way to differentiate between label text and control text in properties [Bug]: 'Select' Element does not apply custom theme color to label Apr 17, 2024
@placidic
Copy link
Author

We've also tried a few things like using the CSS scripts to modify the text label, which oddly worked while in edit mode, but when you would preview or view the app, the updated colors would disappear and revert back to the incorrect color.

There is also no current way to differentiate between colors within the label vs the control (like the text inside the dropdown) - might be a feature to look to add a specific label color property to controls for more flexibility.

@FalkWolsky
Copy link
Contributor

In the upcoming version 2.4 we address exactly all these issues.
You would then have full control of the styles for the component rectangle, the Label, and the Input Fields by itself.

@FalkWolsky FalkWolsky self-assigned this Apr 19, 2024
@placidic
Copy link
Author

placidic commented May 13, 2024

Unfortunately, It appears that the 2.4 Update has created new issues with the theming of the default components. Please see the screenshot below for the v2.4 output of the same settings:
image

@FalkWolsky
Copy link
Contributor

Yes. We addressed it already. It should be fixed in a good way in v2.4.1.
We made a style "reset" in 2.4.0 - which means to clean up the standard values after all changes. Also in the past days, we made sure, that the values of themes are used proper. Please give us some bit more time and with the release it should be ok then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants