Skip to content

Commit 2ff0aea

Browse files
authored
github action for installing goka (#373)
* github action for installing goka * Improved Testing * Switch actual/expected in testify.Equal
1 parent 62eab8a commit 2ff0aea

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+995
-1096
lines changed

.github/workflows/install.yml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
name: install
2+
3+
on:
4+
push:
5+
branches: [master]
6+
pull_request:
7+
branches: [master]
8+
9+
jobs:
10+
install_go_get:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- name: Set up Go
14+
uses: actions/setup-go@v2
15+
with:
16+
go-version: 1.16
17+
18+
- name: Install
19+
shell: bash
20+
run: |
21+
go get -u github.com/lovoo/goka@master
22+

config_test.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,23 @@ import (
44
"testing"
55

66
"github.com/Shopify/sarama"
7-
"github.com/lovoo/goka/internal/test"
7+
"github.com/stretchr/testify/require"
88
)
99

1010
func TestConfig_DefaultConfig(t *testing.T) {
1111
t.Run("equal", func(t *testing.T) {
1212
cfg := DefaultConfig()
13-
test.AssertTrue(t, cfg.Version == sarama.V2_0_0_0)
14-
test.AssertTrue(t, cfg.Consumer.Return.Errors == true)
15-
test.AssertTrue(t, cfg.Consumer.MaxProcessingTime == defaultMaxProcessingTime)
16-
test.AssertTrue(t, cfg.Consumer.Offsets.Initial == sarama.OffsetNewest)
17-
test.AssertTrue(t, cfg.Producer.RequiredAcks == sarama.WaitForLocal)
18-
test.AssertTrue(t, cfg.Producer.Compression == sarama.CompressionSnappy)
19-
test.AssertTrue(t, cfg.Producer.Flush.Frequency == defaultFlushFrequency)
20-
test.AssertTrue(t, cfg.Producer.Flush.Bytes == defaultFlushBytes)
21-
test.AssertTrue(t, cfg.Producer.Return.Successes == true)
22-
test.AssertTrue(t, cfg.Producer.Return.Errors == true)
23-
test.AssertTrue(t, cfg.Producer.Retry.Max == defaultProducerMaxRetries)
13+
require.True(t, cfg.Version == sarama.V2_0_0_0)
14+
require.True(t, cfg.Consumer.Return.Errors == true)
15+
require.True(t, cfg.Consumer.MaxProcessingTime == defaultMaxProcessingTime)
16+
require.True(t, cfg.Consumer.Offsets.Initial == sarama.OffsetNewest)
17+
require.True(t, cfg.Producer.RequiredAcks == sarama.WaitForLocal)
18+
require.True(t, cfg.Producer.Compression == sarama.CompressionSnappy)
19+
require.True(t, cfg.Producer.Flush.Frequency == defaultFlushFrequency)
20+
require.True(t, cfg.Producer.Flush.Bytes == defaultFlushBytes)
21+
require.True(t, cfg.Producer.Return.Successes == true)
22+
require.True(t, cfg.Producer.Return.Errors == true)
23+
require.True(t, cfg.Producer.Retry.Max == defaultProducerMaxRetries)
2424
})
2525
}
2626

@@ -29,7 +29,7 @@ func TestConfig_ReplaceGlobalConfig(t *testing.T) {
2929
custom := DefaultConfig()
3030
custom.Version = sarama.V0_8_2_0
3131
ReplaceGlobalConfig(custom)
32-
test.AssertEqual(t, globalConfig.Version, custom.Version)
32+
require.Equal(t, custom.Version, globalConfig.Version)
3333
})
3434
t.Run("panic", func(t *testing.T) {
3535
defer func() {

0 commit comments

Comments
 (0)