Skip to content

Commit 9d40a64

Browse files
committed
Fix small memory leak in new join feature - see 5ab9168
1 parent fda06a6 commit 9d40a64

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

src/pipeline.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1369,6 +1369,9 @@ class PipelineWorker : public Napi::AsyncWorker {
13691369
for (sharp::InputDescriptor *input : baton->joinChannelIn) {
13701370
delete input;
13711371
}
1372+
for (sharp::InputDescriptor *input : baton->join) {
1373+
delete input;
1374+
}
13721375
delete baton;
13731376

13741377
// Decrement processing task counter

test/leak/sharp.supp

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -936,6 +936,24 @@
936936
...
937937
fun:_ZN2v88internal18ArrayBufferSweeper10ReleaseAllEv
938938
}
939+
{
940+
cond_v8_ZN2v88internal8compiler12PipelineImpl13OptimizeGraphEPNS1_7LinkageE
941+
Memcheck:Cond
942+
...
943+
fun:_ZN2v88internal8compiler12PipelineImpl13OptimizeGraphEPNS1_7LinkageE
944+
}
945+
{
946+
cond_v8_ZN2v88internal4Heap20HasLowAllocationRateEv
947+
Memcheck:Cond
948+
...
949+
fun:_ZN2v88internal4Heap20HasLowAllocationRateEv
950+
}
951+
{
952+
cond_v8_ZN2v88internal4Heap15RecomputeLimitsENS0_16GarbageCollectorENS_4base9TimeTicksE
953+
Memcheck:Cond
954+
...
955+
fun:_ZN2v88internal4Heap15RecomputeLimitsENS0_16GarbageCollectorENS_4base9TimeTicksE
956+
}
939957
{
940958
cond_node_Builtins_JSEntry
941959
Memcheck:Cond

0 commit comments

Comments
 (0)