-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker mode doesn't work on Windows #383
Comments
Thanks for reporting @dmitrc! mind creating a PR to fix this? |
I can try to find time around the end of the week, but if you can get to it sooner, please be my guest. From my brief research, the first value (before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
On Windows,
process.cwd()
includes a colon (:
), which breaks the-v
argument to the Docker CLI.Here is the relevant line in source code:
https://github.com/lost-pixel/lost-pixel/blob/6db31948aef97f10ea9c7b1a8fa8dd3a0ce2dd49/src/docker-runner/utils.ts#L23C5-L23C44
How to reproduce
npx lost-pixel docker
Expected behavior
Docker mode generates the images and diff them as expected
Lost Pixel information
N/A
lost-pixel logs from CI
N/A
The text was updated successfully, but these errors were encountered: