Improve type hint #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrtmy
commented
Dec 24, 2023
| @@ -85,5 +85,5 @@ async def init( | |||
| cls.lua_sha = await redis.script_load(cls.lua_script) | |||
|
|
|||
| @classmethod | |||
| async def close(cls): | |||
| async def close(cls) -> None: | |||
There was a problem hiding this comment.
In my project mypy says...
error: Call to untyped function "close" of "FastAPILimiter" in typed context [no-untyped-call]
tkrtmy
commented
Dec 24, 2023
| milliseconds: Annotated[int, Field(ge=-1)] = 0, | ||
| seconds: Annotated[int, Field(ge=-1)] = 0, | ||
| minutes: Annotated[int, Field(ge=-1)] = 0, | ||
| hours: Annotated[int, Field(ge=-1)] = 0, |
There was a problem hiding this comment.
I migrated according to this
https://github.com/pydantic/pydantic/blob/19fa86cbfcc7b64c5d59c04c38fa80b497f275a2/pydantic/types.py#L157-L182
tkrtmy
commented
Dec 24, 2023
| lua_sha: Optional[str] = None | ||
| identifier: Optional[Callable] = None | ||
| http_callback: Optional[Callable] = None | ||
| ws_callback: Optional[Callable] = None |
|
@long2ice It would be great if you could review this Pull Request. |
|
Looks like CI failed, I will fix it later. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'd like to benefit from a type hint.
This is a trivial change for that purpose.