Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WaitForExpect in Testing docs #159

Open
connorshea opened this issue May 22, 2022 · 1 comment
Open

Replace WaitForExpect in Testing docs #159

connorshea opened this issue May 22, 2022 · 1 comment
Labels
📚 documentation Improvements or additions to documentation

Comments

@connorshea
Copy link
Contributor

Essentially, the most recent versions of Vue CLI/Jest don't play nicely with WaitForExpect anymore, unfortunately. Because of this, I had to switch to waitFor() from the @vue/testing-library package. Only once I did that was I able to upgrade to Jest v27. The "Writing Tests" docs recommend the waitForExpect package, but it might be a good idea to update that to recommend testing library's waitFor, or at least mention it as an alternative? https://villus.logaretm.com/guide/testing#writing-tests

I have a commit here with some more details and the specific change I ended up going with for my own project: connorshea/vglist-frontend@6aa9128

@logaretm logaretm added the 📚 documentation Improvements or additions to documentation label May 23, 2022
@logaretm
Copy link
Owner

logaretm commented Jun 6, 2022

So I upgraded Jest's dependencies to 28 and the tests seem to pass even with wait-for-expect. I will investigate it more if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants