Bugfix: Update lambda response processing #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebpetway
changed the title
|
@ebpetway Thanks, Eric! A few of the test cases are failing after the change, do you think you could update those as well? |
|
@logandk Thanks for taking a look, tests updated! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
- Coverage 98.18% 98.18% -0.01%
==========================================
Files 5 5
Lines 607 605 -2
Branches 72 72
==========================================
- Hits 596 594 -2
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
Awesome, thanks @ebpetway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
Issue: In
invokeHandler,console.logwas being captured to get string response from lambda invocation, but when being used for manage commands, nothing was actually getting captured byconsole.log, the JSON parsing of the output would fail since it was parsing an empty string, and the command would always return with 0 status code instead of a 1 as expected for failed commands.This uses the temporary stdout override already in place to capture the return string from the lambda.