Simplify Flask instrumentation #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies Flask instrumentation by hooking into `dispatch_request`. This is less error prone than the earlier approach of overloading `add_url_rule` and supports Blueprints and Pluggable Views. Fixes logandk/serverless-wsgi#130
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 53.64% 53.69% +0.05%
==========================================
Files 107 107
Lines 3128 3123 -5
==========================================
- Hits 1678 1677 -1
+ Misses 1450 1446 -4
Continue to review full report at Codecov.
|
medikoo
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies Flask instrumentation by hooking into
dispatch_request.This is less error prone than the earlier approach of overloading
add_url_ruleand supports both Blueprints and Pluggable Views.Fixes logandk/serverless-wsgi#130