Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed etcd storage class name parameter does not match between template and values.yaml #1756

Closed
virtualdxs opened this issue May 8, 2024 · 2 comments · Fixed by #1758
Assignees
Labels

Comments

@virtualdxs
Copy link

What happened?

The helm chart's values.controlPlane.backingStore.etcd.deploy.statefulSet.persistence.volumeClaim.storageClass is ignored and the default storageClass is used. This seems to be due to https://github.com/loft-sh/vcluster/blob/v0.20.0-beta.2/chart/templates/etcd-statefulset.yaml#L47 referencing className rather than storageClass.

What did you expect to happen?

Specifying a storageClass for etcd would work

How can we reproduce it (as minimally and precisely as possible)?

Deploy with Helm using the following values.yaml:

controlPlane:
  backingStore:
    etcd:
      deploy:
        enabled: true
        statefulSet:
          persistence:
            volumeClaim:
              className: rook-cephfs

Anything else we need to know?

No response

Host cluster Kubernetes version

$ kubectl version
Client Version: v1.29.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.4+k3s2

Host cluster Kubernetes distribution

k3s

vlcuster version

Not using vcluster cli; helm version is `0.20.0-beta.2`

Vcluster Kubernetes distribution(k3s(default)), k8s, k0s)

k8s I think; I did not specify and this is on v0.20

OS and Arch

OS: Rocky Linux 9
Arch: x86_64
@joaocc
Copy link
Contributor

joaocc commented May 10, 2024

We also have the same issue... in EKS with k3s and etcd it always uses gp2

@neogopher neogopher self-assigned this May 10, 2024
@neogopher
Copy link
Collaborator

Hi @virtualdxs 👋 ,
Thanks for creating this issue and @joaocc also for confirming.

I am looking into this issue and fix is on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants