Skip to content

Commit aae673a

Browse files
committed
feat: update test markers
1 parent 81d63c0 commit aae673a

File tree

4 files changed

+32
-8
lines changed

4 files changed

+32
-8
lines changed

tests/aws/services/events/test_events.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ def test_list_event_buses_with_limit(self, create_event_bus, aws_client, snapsho
651651
)
652652
snapshot.match("list-event-buses-limit-next-token", response)
653653

654-
@markers.aws.unknown
654+
@markers.aws.needs_fixing # TODO use fixture setup_sqs_queue_as_event_target to simplify
655655
@pytest.mark.skipif(is_aws_cloud(), reason="not validated")
656656
@pytest.mark.parametrize("strategy", ["standard", "domain", "path"])
657657
def test_put_events_into_event_bus(

tests/aws/services/events/test_events_integrations.py

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,9 @@ def test_put_events_with_target_sqs_new_region(aws_client_factory):
8383
assert "EventId" in response.get("Entries")[0]
8484

8585

86-
@markers.aws.unknown
87-
def test_put_events_with_target_sqs_event_detail_match(put_events_with_filter_to_sqs):
86+
@markers.aws.validated
87+
@pytest.mark.skipif(is_v2_provider(), reason="V2 provider does not support this feature yet")
88+
def test_put_events_with_target_sqs_event_detail_match(put_events_with_filter_to_sqs, snapshot):
8889
entries1 = [
8990
{
9091
"Source": TEST_EVENT_PATTERN["source"][0],
@@ -100,17 +101,25 @@ def test_put_events_with_target_sqs_event_detail_match(put_events_with_filter_to
100101
}
101102
]
102103
entries_asserts = [(entries1, True), (entries2, False)]
103-
put_events_with_filter_to_sqs(
104+
messages = put_events_with_filter_to_sqs(
104105
pattern={"detail": {"EventType": ["0", "1"]}},
105106
entries_asserts=entries_asserts,
106107
input_path="$.detail",
107108
)
108109

110+
snapshot.add_transformers_list(
111+
[
112+
snapshot.transform.key_value("ReceiptHandle", reference_replacement=False),
113+
snapshot.transform.key_value("MD5OfBody", reference_replacement=False),
114+
],
115+
)
116+
snapshot.match("messages", messages)
117+
109118

110119
# TODO: further unify/parameterize the tests for the different target types below
111120

112121

113-
@markers.aws.unknown
122+
@markers.aws.needs_fixing
114123
@pytest.mark.parametrize("strategy", ["standard", "domain", "path"])
115124
def test_put_events_with_target_sns(
116125
monkeypatch,
@@ -179,7 +188,7 @@ def test_put_events_with_target_sns(
179188
)
180189

181190

182-
@markers.aws.unknown
191+
@markers.aws.needs_fixing
183192
def test_put_events_with_target_lambda(create_lambda_function, cleanups, aws_client, clean_up):
184193
rule_name = f"rule-{short_uid()}"
185194
function_name = f"lambda-func-{short_uid()}"
@@ -484,7 +493,7 @@ def check_invocation():
484493
retry(check_invocation, sleep=5, retries=15)
485494

486495

487-
@markers.aws.unknown
496+
@markers.aws.needs_fixing
488497
def test_put_events_with_target_firehose(aws_client, clean_up):
489498
s3_bucket = "s3-{}".format(short_uid())
490499
s3_prefix = "testeventdata"

tests/aws/services/events/test_events_integrations.snapshot.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,5 +129,20 @@
129129
}
130130
]
131131
}
132+
},
133+
"tests/aws/services/events/test_events_integrations.py::test_put_events_with_target_sqs_event_detail_match": {
134+
"recorded-date": "07-05-2024, 10:40:38",
135+
"recorded-content": {
136+
"messages": [
137+
{
138+
"MessageId": "<uuid:1>",
139+
"ReceiptHandle": "receipt-handle",
140+
"MD5OfBody": "m-d5-of-body",
141+
"Body": {
142+
"EventType": "1"
143+
}
144+
}
145+
]
146+
}
132147
}
133148
}

tests/aws/services/events/test_events_integrations.validation.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"last_validated_date": "2024-04-26T08:43:27+00:00"
1010
},
1111
"tests/aws/services/events/test_events_integrations.py::test_put_events_with_target_sqs_event_detail_match": {
12-
"last_validated_date": "2024-03-26T15:50:07+00:00"
12+
"last_validated_date": "2024-05-07T10:40:38+00:00"
1313
},
1414
"tests/aws/services/events/test_events_integrations.py::test_should_ignore_schedules_for_put_event": {
1515
"last_validated_date": "2024-03-26T15:51:47+00:00"

0 commit comments

Comments
 (0)