Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove ECS-ECR container app tutorial #870

Open
joe4dev opened this issue Oct 18, 2023 · 0 comments
Open

Fix or remove ECS-ECR container app tutorial #870

joe4dev opened this issue Oct 18, 2023 · 0 comments

Comments

@joe4dev
Copy link
Member

joe4dev commented Oct 18, 2023

The ECS-ECR container app tutorial is broken and has many issues: https://docs.localstack.cloud/tutorials/ecs-ecr-container-app/

We should either fix or remove it.

Motivation

  • Initially reported by a pro customer
  • Previously discussed in a prior update (May 2023) to this app: improve the lambda container images tutorial #628 (comment)
  • I retested (2023-10-17) and the tutorial and it still doesn't work for me.
    • The CloudFormation stack fails to deploy with a validation error An error occurred (ValidationError) when calling the CreateTargetGroup operation: A VPC ID must be specified

Further suggestions for improvement

  • Use concrete naming suggestions instead of placeholders that need to be changed for no reason
  • Avoid using naming collisions for <STACK_NAME> being used twice in different context
  • Copy/pasting long blobs of partial files and then making them fit together is very cumbersome
  • Consider providing a minimal example or use a repository to bootstrap the tutorial. The CloudFormation template is unnecessarily complex for the intended demonstration purpose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant