Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only half of values is read from the file recorded with WavePro HD #1

Closed
emoehr opened this issue May 25, 2023 · 3 comments · Fixed by #2
Closed

only half of values is read from the file recorded with WavePro HD #1

emoehr opened this issue May 25, 2023 · 3 comments · Fixed by #2
Assignees

Comments

@emoehr
Copy link

emoehr commented May 25, 2023

Hello.
I've noticed that lecroyscope.Trace() reads only half of the data recorded with the WavePro HD scope. Reason is that the array length of the data is taken from header["wave_array_count"] instead of header["wave_array1"]. If I replace that in the reading/file.py (line 116) then everything works correctly at least for singe traces and sequences. I don't know if this is scope model specific or a general solution and weather it works for all types of data though.

kind regards, Ekaterina

@lobis lobis self-assigned this May 25, 2023
@lobis
Copy link
Owner

lobis commented May 25, 2023

Hello @emoehr, thanks for posting an issue!

When I developed this library I only had a single model of oscilloscope to test it with so I guess this kind of problems were very likely. In my experience the wave_array_count should contain the length of the data, but it may not be true in all cases.

Originally I uploaded some files I recorded to the tests section, in order to verify the library works properly.

I would love if you could share some files (in the "trc" format, binary) so I could check this issue myself and see how best to fix it! (please not more than a few KB in length 🙏🏻 )

@emoehr
Copy link
Author

emoehr commented May 25, 2023

Hi, I give one of the files I work with. This is a single time trace from -2 to 8 ms, 10MSa/s. Github doesn't take .trc files so I pack it into zip format. Hope this helps.
C2--test--00001.zip

@lobis lobis linked a pull request May 25, 2023 that will close this issue
@lobis lobis closed this as completed in #2 May 25, 2023
@lobis
Copy link
Owner

lobis commented May 25, 2023

Thanks @emoehr , it was indeed a bug. I fixed it and published a new release, it should work now after you update (pip install lecroyscope).

Thanks again for reporting the bug, please free to keep reporting new bugs and even to submit PRs with fixes or new features!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants