Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 功能选择变量不完全生效 #4562

Open
DaLiWan666 opened this issue Oct 31, 2024 · 6 comments · May be fixed by #4609
Open

[Bug] 功能选择变量不完全生效 #4562

DaLiWan666 opened this issue Oct 31, 2024 · 6 comments · May be fixed by #4609
Labels
🐛 Bug Something isn't working | 缺陷

Comments

@DaLiWan666
Copy link

📦 Environment

Docker

📌 Version

1.26

💻 Operating System

Ubuntu

🌐 Browser

Edge

🐛 Bug Description

FEATURE_FLAGS变量内,-edit_agent功能不完全生效,没有完全隐藏,加入此选项后,
image这个位置的编辑的按钮确实消失了,但是点击标题处头像,依旧可以换出编辑界面
image
image

📷 Recurrence Steps

FEATURE_FLAGS变量内,加入-edit_agent

🚦 Expected Behavior

图标点击后的也一并隐藏

📝 Additional Information

No response

@DaLiWan666 DaLiWan666 added the 🐛 Bug Something isn't working | 缺陷 label Oct 31, 2024
@github-project-automation github-project-automation bot moved this to Roadmap - Chat 1.x in Lobe Chat Routine Oct 31, 2024
Copy link

dosubot bot commented Oct 31, 2024

The issue you're experiencing with the -edit_agent feature flag not fully hiding the edit interface might be due to the logic not being applied consistently across all components. While the edit button is hidden, the avatar click event might still trigger the edit interface.

To address this, you should check if the -edit_agent flag is being consistently checked in the logic that handles the avatar click event. Ensure that the isAgentEditable state, which is mapped from the edit_agent flag, is used to conditionally render or disable the edit interface when the avatar is clicked.

If the logic for handling the avatar click event does not currently check the isAgentEditable state, you may need to update it to respect this flag. This would involve adding a condition to prevent the edit interface from being displayed if isAgentEditable is false.

Unfortunately, I couldn't find specific details in the codebase about how the avatar click event is handled, so you might need to review the relevant component or function to ensure the flag is being applied correctly.

To continue talking to Dosu, mention @dosu.

@arvinxx
Copy link
Contributor

arvinxx commented Oct 31, 2024

这个应该是漏掉了…

@DaLiWan666
Copy link
Author

这个应该是漏掉了…

那可以修复下吗?

@mushan0x0 mushan0x0 linked a pull request Nov 5, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷
Projects
Status: Roadmap - Chat 1.x
Development

Successfully merging a pull request may close this issue.

3 participants
@arvinxx @DaLiWan666 and others