Skip to content

Include default command settings in stack config file #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ncoghlan opened this issue Oct 21, 2024 · 2 comments
Open

Include default command settings in stack config file #29

ncoghlan opened this issue Oct 21, 2024 · 2 comments
Labels
Affects: Command Line Affects the command line interface Affects: Spec Format Affect the stack specification format Category: Enhancement New feature or request

Comments

@ncoghlan
Copy link
Collaborator

ncoghlan commented Oct 21, 2024

There are several locking, build, and publishing settings which could reasonably be considered part of the stack specification:

While settings these globally or per-user doesn't necessarily make sense (although #20 would allow that to some degree), it does make sense to allow the stack specification file to include a [config] section which changes the default values used for various settings.

https://maxb2.github.io/typer-config/latest/ may be a useful dependency to consider for this purpose (as this idea would be similar to the "pyproject.toml section" approach described in https://maxb2.github.io/typer-config/latest/examples/pyproject/ )

@ncoghlan ncoghlan added Category: Enhancement New feature or request Affects: Command Line Affects the command line interface Affects: Spec Format Affect the stack specification format labels Oct 21, 2024
@ncoghlan
Copy link
Collaborator Author

Another good candidate for inclusion as a stack config setting:

@ncoghlan
Copy link
Collaborator Author

I'm currently leaning against tightly coupling the config file processing with the CLI option processing, since some of the settings I'd like to be configurable at the project level don't really make sense as CLI options:

  • marking an entire stack definition file as platform specific
  • choosing a locking mode (if that ends up being configurable instead of simply changing the locking algorithm)
  • choosing a layer archiving mode (as per Add a "conceptual" layer archiving mode #146)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Command Line Affects the command line interface Affects: Spec Format Affect the stack specification format Category: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant