Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GVNSink] Reuse value numbering from GVN #92198

Open
hiraditya opened this issue May 15, 2024 · 1 comment
Open

[GVNSink] Reuse value numbering from GVN #92198

hiraditya opened this issue May 15, 2024 · 1 comment
Labels
llvm:GVN GVN and NewGVN stages (Global value numbering)

Comments

@hiraditya
Copy link
Collaborator

GVNSink has a custom gvn code see:

llvm-project/llvm/lib/Transforms/Scalar/GVNSink.cpp

Line 504 in 93b4705

hash_code H = exp->getHashValue([=](Value *V) { return lookupOrAdd(V); });
This is not maintainable, we can reuse the one from GVN similar to how GVNHoist does it https://llvm.org/doxygen/GVNHoist_8cpp_source.html#l00225.
@hiraditya hiraditya added llvm:GVN GVN and NewGVN stages (Global value numbering) and removed new issue labels May 15, 2024
@hiraditya
Copy link
Collaborator Author

This is a follow up from the discussion in #77852 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
llvm:GVN GVN and NewGVN stages (Global value numbering)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiraditya